Skip to content

Commit af2e2ec

Browse files
authored
fix(asio): link with advapi32 and bump asio-sys to 0.2.6 (#1105)
Change GitHub Actions to build ASIO examples instead of checking them, preventing regression of such linker errors in the future.
1 parent 51f0b85 commit af2e2ec

6 files changed

Lines changed: 16 additions & 5 deletions

File tree

.github/workflows/platforms.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,9 @@ jobs:
219219
- name: Check examples (all features)
220220
run: cargo +${{ steps.msrv.outputs.all-features }} check --examples --all-features --workspace --verbose
221221

222-
- name: Check ASIO examples
222+
- name: Build ASIO examples
223223
working-directory: asio-sys
224-
run: cargo +${{ env.MSRV_WINDOWS }} check --examples --verbose --workspace
224+
run: cargo +${{ env.MSRV_WINDOWS }} build --examples --verbose --workspace
225225

226226
# macOS ARM64
227227
macos:

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,16 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
## [0.17.3] - 2026-02-17
8+
## [0.17.3] - 2026-02-18
99

1010
### Changed
1111

1212
- Reverted SemVer-breaking `DeviceBusy` error variant addition.
1313

14+
### Fixed
15+
16+
- **ASIO**: Fix linker errors.
17+
1418
## [0.17.2] - 2026-02-08 [YANKED]
1519

1620
### Added

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ windows = { version = ">=0.59, <=0.62", features = [
8080
"Win32_UI_Shell_PropertiesSystem",
8181
] }
8282
audio_thread_priority = { version = "0.34", optional = true }
83-
asio-sys = { version = "0.2", path = "asio-sys", optional = true }
83+
asio-sys = { version = "0.2.6", path = "asio-sys", optional = true }
8484
num-traits = { version = "0.2", optional = true }
8585
jack = { version = "0.13", optional = true }
8686

asio-sys/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [0.2.6] - 2026-02-17
9+
10+
### Fixed
11+
- Link `advapi32` to resolve Windows Registry API symbols.
12+
813
## [0.2.5] - 2026-01-04
914

1015
### Fixed
@@ -77,6 +82,7 @@ Initial release.
7782
- Support for MSVC toolchain on Windows
7883
- Basic error types: `AsioError`, `LoadDriverError`
7984

85+
[0.2.6]: https://github.com/RustAudio/cpal/compare/asio-sys-v0.2.5...asio-sys-v0.2.6
8086
[0.2.5]: https://github.com/RustAudio/cpal/compare/asio-sys-v0.2.4...asio-sys-v0.2.5
8187
[0.2.4]: https://github.com/RustAudio/cpal/compare/asio-sys-v0.2.3...asio-sys-v0.2.4
8288
[0.2.3]: https://github.com/RustAudio/cpal/compare/asio-sys-v0.2.2...asio-sys-v0.2.3

asio-sys/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "asio-sys"
3-
version = "0.2.5"
3+
version = "0.2.6"
44
authors = ["Tom Gowan <tomrgowan@gmail.com>"]
55
description = "Low-level interface and binding generation for the steinberg ASIO SDK."
66
repository = "https://github.com/RustAudio/cpal/"

asio-sys/build.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ fn main() {
7070
}
7171

7272
// Print out links to needed libraries
73+
println!("cargo:rustc-link-lib=dylib=advapi32");
7374
println!("cargo:rustc-link-lib=dylib=ole32");
7475
println!("cargo:rustc-link-lib=dylib=user32");
7576
println!("cargo:rustc-link-search={}", out_dir.display());

0 commit comments

Comments
 (0)