Skip to content

Commit f3845d7

Browse files
Dr. David Alan Gilbertmartinkpetersen
authored andcommitted
scsi: bfa: Remove unused bfa_core code
bfa_get_pciids and bfa_cfg_get_min aren't called anywhere; remove them together with the bfa_pciid_s used by bfa_get_pciids. (Build tested, I don't have the card) Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Link: https://lore.kernel.org/r/20240915125633.25036-2-linux@treblig.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 9852d85 commit f3845d7

2 files changed

Lines changed: 0 additions & 45 deletions

File tree

drivers/scsi/bfa/bfa.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -138,14 +138,6 @@ bfa_reqq_winit(struct bfa_reqq_wait_s *wqe, void (*qresume) (void *cbarg),
138138
} while (0)
139139

140140

141-
/*
142-
* PCI devices supported by the current BFA
143-
*/
144-
struct bfa_pciid_s {
145-
u16 device_id;
146-
u16 vendor_id;
147-
};
148-
149141
extern char bfa_version[];
150142

151143
struct bfa_iocfc_regs_s {
@@ -408,9 +400,7 @@ int bfa_iocfc_get_pbc_vports(struct bfa_s *bfa,
408400
(((&(_bfa)->modules.dconf_mod)->min_cfg) \
409401
? BFA_LUNMASK_MINCFG : ((bfa_get_lun_mask(_bfa))->status))
410402

411-
void bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids);
412403
void bfa_cfg_get_default(struct bfa_iocfc_cfg_s *cfg);
413-
void bfa_cfg_get_min(struct bfa_iocfc_cfg_s *cfg);
414404
void bfa_cfg_get_meminfo(struct bfa_iocfc_cfg_s *cfg,
415405
struct bfa_meminfo_s *meminfo,
416406
struct bfa_s *bfa);

drivers/scsi/bfa/bfa_core.c

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1933,24 +1933,6 @@ bfa_comp_free(struct bfa_s *bfa, struct list_head *comp_q)
19331933
}
19341934
}
19351935

1936-
/*
1937-
* Return the list of PCI vendor/device id lists supported by this
1938-
* BFA instance.
1939-
*/
1940-
void
1941-
bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids)
1942-
{
1943-
static struct bfa_pciid_s __pciids[] = {
1944-
{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_FC_8G2P},
1945-
{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_FC_8G1P},
1946-
{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT},
1947-
{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT_FC},
1948-
};
1949-
1950-
*npciids = ARRAY_SIZE(__pciids);
1951-
*pciids = __pciids;
1952-
}
1953-
19541936
/*
19551937
* Use this function query the default struct bfa_iocfc_cfg_s value (compiled
19561938
* into BFA layer). The OS driver can then turn back and overwrite entries that
@@ -1987,20 +1969,3 @@ bfa_cfg_get_default(struct bfa_iocfc_cfg_s *cfg)
19871969
cfg->drvcfg.delay_comp = BFA_FALSE;
19881970

19891971
}
1990-
1991-
void
1992-
bfa_cfg_get_min(struct bfa_iocfc_cfg_s *cfg)
1993-
{
1994-
bfa_cfg_get_default(cfg);
1995-
cfg->fwcfg.num_ioim_reqs = BFA_IOIM_MIN;
1996-
cfg->fwcfg.num_tskim_reqs = BFA_TSKIM_MIN;
1997-
cfg->fwcfg.num_fcxp_reqs = BFA_FCXP_MIN;
1998-
cfg->fwcfg.num_uf_bufs = BFA_UF_MIN;
1999-
cfg->fwcfg.num_rports = BFA_RPORT_MIN;
2000-
cfg->fwcfg.num_fwtio_reqs = 0;
2001-
2002-
cfg->drvcfg.num_sgpgs = BFA_SGPG_MIN;
2003-
cfg->drvcfg.num_reqq_elems = BFA_REQQ_NELEMS_MIN;
2004-
cfg->drvcfg.num_rspq_elems = BFA_RSPQ_NELEMS_MIN;
2005-
cfg->drvcfg.min_cfg = BFA_TRUE;
2006-
}

0 commit comments

Comments
 (0)