Skip to content

Commit f087965

Browse files
efzrhvinodkoul
authored andcommitted
dmaengine: ptdma: Remove unused pointer dma_cmd_cache
The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit 'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA resource")' but it was never used. Signed-off-by: Eder Zulian <ezulian@redhat.com> Reviewed-by: Nathan Lynch <nathan.lynch@amd.com> Link: https://lore.kernel.org/r/20250415121312.870124-1-ezulian@redhat.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 82922fc commit f087965

2 files changed

Lines changed: 4 additions & 13 deletions

File tree

drivers/dma/amd/ptdma/ptdma-dmaengine.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -590,18 +590,14 @@ int pt_dmaengine_register(struct pt_device *pt)
590590
desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
591591
"%s-dmaengine-desc-cache",
592592
dev_name(pt->dev));
593-
if (!desc_cache_name) {
594-
ret = -ENOMEM;
595-
goto err_cache;
596-
}
593+
if (!desc_cache_name)
594+
return -ENOMEM;
597595

598596
pt->dma_desc_cache = kmem_cache_create(desc_cache_name,
599597
sizeof(struct pt_dma_desc), 0,
600598
SLAB_HWCACHE_ALIGN, NULL);
601-
if (!pt->dma_desc_cache) {
602-
ret = -ENOMEM;
603-
goto err_cache;
604-
}
599+
if (!pt->dma_desc_cache)
600+
return -ENOMEM;
605601

606602
dma_dev->dev = pt->dev;
607603
dma_dev->src_addr_widths = DMA_SLAVE_BUSWIDTH_64_BYTES;
@@ -655,9 +651,6 @@ int pt_dmaengine_register(struct pt_device *pt)
655651
err_reg:
656652
kmem_cache_destroy(pt->dma_desc_cache);
657653

658-
err_cache:
659-
kmem_cache_destroy(pt->dma_cmd_cache);
660-
661654
return ret;
662655
}
663656
EXPORT_SYMBOL_GPL(pt_dmaengine_register);
@@ -669,5 +662,4 @@ void pt_dmaengine_unregister(struct pt_device *pt)
669662
dma_async_device_unregister(dma_dev);
670663

671664
kmem_cache_destroy(pt->dma_desc_cache);
672-
kmem_cache_destroy(pt->dma_cmd_cache);
673665
}

drivers/dma/amd/ptdma/ptdma.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@ struct pt_device {
254254
/* Support for the DMA Engine capabilities */
255255
struct dma_device dma_dev;
256256
struct pt_dma_chan *pt_dma_chan;
257-
struct kmem_cache *dma_cmd_cache;
258257
struct kmem_cache *dma_desc_cache;
259258

260259
wait_queue_head_t lsb_queue;

0 commit comments

Comments
 (0)