drm/radeon: Remove unnecessary NULL test before kfree in 'radeon_connector_free_edid'

srishanm · alexdeucher · commit efd9d065de67 · 2023-07-27T14:59:30.000-04:00
Fixes the below:

WARNING: kfree(NULL) is safe and this check is probably not required.

Cc: Christian König &lt;christian.koenig@amd.com&gt;
Cc: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Signed-off-by: Srinivasan Shanmugam &lt;srinivasan.shanmugam@amd.com&gt;
Reviewed-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -333,10 +333,8 @@ static void radeon_connector_free_edid(struct drm_connector *connector)
 {
 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
 
-	if (radeon_connector->edid) {
-		kfree(radeon_connector->edid);
-		radeon_connector->edid = NULL;
-	}
+	kfree(radeon_connector->edid);
+	radeon_connector->edid = NULL;
 }
 
 static int radeon_ddc_get_modes(struct drm_connector *connector)

Original file line number	Diff line number	Diff line change
`@@ -333,10 +333,8 @@ static void radeon_connector_free_edid(struct drm_connector *connector)`
`333`	`333`	`{`
`334`	`334`	`struct radeon_connector *radeon_connector = to_radeon_connector(connector);`
`335`	`335`
`336`		`- if (radeon_connector->edid) {`
`337`		`- kfree(radeon_connector->edid);`
`338`		`- radeon_connector->edid = NULL;`
`339`		`- }`
	`336`	`+ kfree(radeon_connector->edid);`
	`337`	`+ radeon_connector->edid = NULL;`
`340`	`338`	`}`
`341`	`339`
`342`	`340`	`static int radeon_ddc_get_modes(struct drm_connector *connector)`