Skip to content

Commit ee32072

Browse files
geerturobherring
authored andcommitted
of: unittest: Add separators to of_unittest_overlay_high_level()
It is hard to see the start and end of each individual test in of_unittest_overlay_high_level(). Add visual cues in the form of separator comments, like was done in of_unittest_overlay_notify(). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/84530100a54a1fac932008057746015e65bc4d9a.1690533838.git.geert+renesas@glider.be Signed-off-by: Rob Herring <robh@kernel.org>
1 parent 0676aee commit ee32072

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/of/unittest.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3654,6 +3654,8 @@ static __init void of_unittest_overlay_high_level(void)
36543654

36553655
/* now do the normal overlay usage test */
36563656

3657+
/* --- overlay --- */
3658+
36573659
EXPECT_BEGIN(KERN_ERR,
36583660
"OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/status");
36593661
EXPECT_BEGIN(KERN_ERR,
@@ -3704,6 +3706,8 @@ static __init void of_unittest_overlay_high_level(void)
37043706

37053707
unittest(ret, "Adding overlay 'overlay' failed\n");
37063708

3709+
/* --- overlay_bad_add_dup_node --- */
3710+
37073711
EXPECT_BEGIN(KERN_ERR,
37083712
"OF: overlay: ERROR: multiple fragments add and/or delete node /testcase-data-2/substation@100/motor-1/controller");
37093713
EXPECT_BEGIN(KERN_ERR,
@@ -3725,6 +3729,8 @@ static __init void of_unittest_overlay_high_level(void)
37253729
EXPECT_END(KERN_ERR,
37263730
"OF: overlay: ERROR: multiple fragments add and/or delete node /testcase-data-2/substation@100/motor-1/controller");
37273731

3732+
/* --- overlay_bad_add_dup_prop --- */
3733+
37283734
EXPECT_BEGIN(KERN_ERR,
37293735
"OF: overlay: ERROR: multiple fragments add and/or delete node /testcase-data-2/substation@100/motor-1/electric");
37303736
EXPECT_BEGIN(KERN_ERR,
@@ -3750,9 +3756,13 @@ static __init void of_unittest_overlay_high_level(void)
37503756
EXPECT_END(KERN_ERR,
37513757
"OF: overlay: ERROR: multiple fragments add and/or delete node /testcase-data-2/substation@100/motor-1/electric");
37523758

3759+
/* --- overlay_bad_phandle --- */
3760+
37533761
unittest(overlay_data_apply("overlay_bad_phandle", NULL),
37543762
"Adding overlay 'overlay_bad_phandle' failed\n");
37553763

3764+
/* --- overlay_bad_symbol --- */
3765+
37563766
EXPECT_BEGIN(KERN_ERR,
37573767
"OF: changeset: apply failed: REMOVE_PROPERTY /testcase-data-2/substation@100/hvac-medium-2:name");
37583768
EXPECT_BEGIN(KERN_ERR,

0 commit comments

Comments
 (0)