Skip to content

Commit dcec126

Browse files
rtc: ds1307: stop disabling alarms on probe
It is a bad practice to disable alarms on probe or remove as this will prevent alarms across reboots. Link: https://lore.kernel.org/r/20250303223744.1135672-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 0c57c2e commit dcec126

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/rtc/rtc-ds1307.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1807,10 +1807,8 @@ static int ds1307_probe(struct i2c_client *client)
18071807
* For some variants, be sure alarms can trigger when we're
18081808
* running on Vbackup (BBSQI/BBSQW)
18091809
*/
1810-
if (want_irq || ds1307_can_wakeup_device) {
1810+
if (want_irq || ds1307_can_wakeup_device)
18111811
regs[0] |= DS1337_BIT_INTCN | chip->bbsqi_bit;
1812-
regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);
1813-
}
18141812

18151813
regmap_write(ds1307->regmap, DS1337_REG_CONTROL,
18161814
regs[0]);

0 commit comments

Comments
 (0)