io_uring/msg_ring: tighten requirement for remote posting

axboe · axboe · commit d57afd8bb7f2 · 2024-06-24T08:39:34.000-06:00
Currently this is gated on whether or not the target ring needs a local
completion - and if so, whether or not we're running on the right task.
The use case for same thread cross posting is probably a lot less
relevant than remote posting. And since we're going to improve this
situation anyway, just gate it on local posting and ignore what task
we're currently running on.

Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/io_uring/msg_ring.c b/io_uring/msg_ring.c
@@ -68,9 +68,7 @@ void io_msg_ring_cleanup(struct io_kiocb *req)
 
 static inline bool io_msg_need_remote(struct io_ring_ctx *target_ctx)
 {
-	if (!target_ctx->task_complete)
-		return false;
-	return current != target_ctx->submitter_task;
+	return target_ctx->task_complete;
 }
 
 static int io_msg_exec_remote(struct io_kiocb *req, task_work_func_t func)

Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,7 @@ void io_msg_ring_cleanup(struct io_kiocb *req)`
`68`	`68`
`69`	`69`	`static inline bool io_msg_need_remote(struct io_ring_ctx *target_ctx)`
`70`	`70`	`{`
`71`		`- if (!target_ctx->task_complete)`
`72`		`- return false;`
`73`		`- return current != target_ctx->submitter_task;`
	`71`	`+ return target_ctx->task_complete;`
`74`	`72`	`}`
`75`	`73`
`76`	`74`	`static int io_msg_exec_remote(struct io_kiocb *req, task_work_func_t func)`