Skip to content

Commit d1da105

Browse files
pujarspH5
authored andcommitted
reset: tegra-bpmp: Restore Handle errors in BPMP response
This reverts following commit 69125b4 ("reset: tegra-bpmp: Revert Handle errors in BPMP response"). The Tegra194 HDA reset failure is fixed by commit d278dc9 ("ALSA: hda/tegra: Fix Tegra194 HDA reset failure"). The temporary revert of original commit c045ceb ("reset: tegra-bpmp: Handle errors in BPMP response") can be removed now. Signed-off-by: Sameer Pujar <spujar@nvidia.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/1641995806-15245-1-git-send-email-spujar@nvidia.com
1 parent da18980 commit d1da105

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

drivers/reset/tegra/reset-bpmp.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
2020
struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
2121
struct mrq_reset_request request;
2222
struct tegra_bpmp_message msg;
23+
int err;
2324

2425
memset(&request, 0, sizeof(request));
2526
request.cmd = command;
@@ -30,7 +31,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
3031
msg.tx.data = &request;
3132
msg.tx.size = sizeof(request);
3233

33-
return tegra_bpmp_transfer(bpmp, &msg);
34+
err = tegra_bpmp_transfer(bpmp, &msg);
35+
if (err)
36+
return err;
37+
if (msg.rx.ret)
38+
return -EINVAL;
39+
40+
return 0;
3441
}
3542

3643
static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,

0 commit comments

Comments
 (0)