octeontx2-pf: fix error handling of devlink port in rvu_rep_create()

harshimogalapalli · kuba-moo · commit b95c8c33ae68 · 2024-12-18T19:23:51.000-08:00
Unregister the devlink port when register_netdev() fails. Fixes: 9ed0343 ("octeontx2-pf: Add devlink port support") Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Link: https://patch.msgid.link/20241217052326.1086191-2-harshit.m.mogalapalli@oracle.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
@@ -690,6 +690,7 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
 		if (err) {
 			NL_SET_ERR_MSG_MOD(extack,
 					   "PFVF representor registration failed");
+			rvu_rep_devlink_port_unregister(rep);
 			free_netdev(ndev);
 			goto exit;
 		}

Original file line number	Diff line number	Diff line change
`@@ -690,6 +690,7 @@ int rvu_rep_create(struct otx2_nic priv, struct netlink_ext_ack extack)`
`690`	`690`	`if (err) {`
`691`	`691`	`NL_SET_ERR_MSG_MOD(extack,`
`692`	`692`	`"PFVF representor registration failed");`
	`693`	`+ rvu_rep_devlink_port_unregister(rep);`
`693`	`694`	`free_netdev(ndev);`
`694`	`695`	`goto exit;`
`695`	`696`	`}`