NFSv4: Fix memory leak in nfs4_set_security_label

mastykin · Trond Myklebust · commit aad11473f8f4 · 2024-05-22T11:27:04.000-04:00
We leak nfs_fattr and nfs4_label every time we set a security xattr.

Signed-off-by: Dmitry Mastykin &lt;mastichi@gmail.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
@@ -6268,6 +6268,7 @@ nfs4_set_security_label(struct inode *inode, const void *buf, size_t buflen)
 	if (status == 0)
 		nfs_setsecurity(inode, fattr);
 
+	nfs_free_fattr(fattr);
 	return status;
 }
 #endif	/* CONFIG_NFS_V4_SECURITY_LABEL */

Original file line number	Diff line number	Diff line change
`@@ -6268,6 +6268,7 @@ nfs4_set_security_label(struct inode inode, const void buf, size_t buflen)`
`6268`	`6268`	`if (status == 0)`
`6269`	`6269`	`nfs_setsecurity(inode, fattr);`
`6270`	`6270`
	`6271`	`+ nfs_free_fattr(fattr);`
`6271`	`6272`	`return status;`
`6272`	`6273`	`}`
`6273`	`6274`	`#endif /* CONFIG_NFS_V4_SECURITY_LABEL */`