ACPI: battery: use sysfs_emit over sprintf

t-8ch · rafaeljw · commit aa532663072c · 2024-06-13T21:26:14.000+02:00
sysfs_emit validates assumptions made by sysfs and is the correct
mechanism to format data for sysfs.

Signed-off-by: Thomas Weißschuh &lt;linux@weissschuh.net&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
@@ -661,7 +661,7 @@ static ssize_t acpi_battery_alarm_show(struct device *dev,
 {
 	struct acpi_battery *battery = to_acpi_battery(dev_get_drvdata(dev));
 
-	return sprintf(buf, "%d\n", battery->alarm * 1000);
+	return sysfs_emit(buf, "%d\n", battery->alarm * 1000);
 }
 
 static ssize_t acpi_battery_alarm_store(struct device *dev,

Original file line number	Diff line number	Diff line change
`@@ -661,7 +661,7 @@ static ssize_t acpi_battery_alarm_show(struct device *dev,`
`661`	`661`	`{`
`662`	`662`	`struct acpi_battery *battery = to_acpi_battery(dev_get_drvdata(dev));`
`663`	`663`
`664`		`- return sprintf(buf, "%d\n", battery->alarm * 1000);`
	`664`	`+ return sysfs_emit(buf, "%d\n", battery->alarm * 1000);`
`665`	`665`	`}`
`666`	`666`
`667`	`667`	`static ssize_t acpi_battery_alarm_store(struct device *dev,`