Skip to content

Commit a4e5af2

Browse files
Mike Tiptonandersson
authored andcommitted
clk: qcom: clk-rpmh: Fix overflow in BCM vote
Valid frequencies may result in BCM votes that exceed the max HW value. Set vote ceiling to BCM_TCS_CMD_VOTE_MASK to ensure the votes aren't truncated, which can result in lower frequencies than desired. Fixes: 04053f4 ("clk: qcom: clk-rpmh: Add IPA clock support") Cc: stable@vger.kernel.org Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com> Reviewed-by: Taniya Das <quic_tdas@quicinc.com> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> Link: https://lore.kernel.org/r/20240809-clk-rpmh-bcm-vote-fix-v2-1-240c584b7ef9@quicinc.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent db30c11 commit a4e5af2

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/clk/qcom/clk-rpmh.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@ static int clk_rpmh_bcm_send_cmd(struct clk_rpmh *c, bool enable)
263263
cmd_state = 0;
264264
}
265265

266+
cmd_state = min(cmd_state, BCM_TCS_CMD_VOTE_MASK);
267+
266268
if (c->last_sent_aggr_state != cmd_state) {
267269
cmd.addr = c->res_addr;
268270
cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state);

0 commit comments

Comments
 (0)