Skip to content

Commit a4dd853

Browse files
nehebkuba-moo
authored andcommitted
net: ibm: emac: use devm for register_netdev
Cleans it up automatically. No need to handle manually. Signed-off-by: Rosen Penev <rosenp@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20240912024903.6201-6-rosenp@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 93a6d4e commit a4dd853

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

  • drivers/net/ethernet/ibm/emac

drivers/net/ethernet/ibm/emac/core.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3182,7 +3182,7 @@ static int emac_probe(struct platform_device *ofdev)
31823182

31833183
netif_carrier_off(ndev);
31843184

3185-
err = register_netdev(ndev);
3185+
err = devm_register_netdev(&ofdev->dev, ndev);
31863186
if (err) {
31873187
printk(KERN_ERR "%pOF: failed to register net device (%d)!\n",
31883188
np, err);
@@ -3248,8 +3248,6 @@ static void emac_remove(struct platform_device *ofdev)
32483248

32493249
DBG(dev, "remove" NL);
32503250

3251-
unregister_netdev(dev->ndev);
3252-
32533251
cancel_work_sync(&dev->reset_work);
32543252

32553253
if (emac_has_feature(dev, EMAC_FTR_HAS_TAH))

0 commit comments

Comments
 (0)