scsi: isci: Return result of sas_register_ha()

dTenebrae · martinkpetersen · commit 9a23ed57abbb · 2023-08-21T16:39:30.000-04:00
To properly manage possible failure of sas_register_ha() in isci_register_sas_ha(), return its result instead of zero Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru> Link: https://lore.kernel.org/r/20230813202336.240874-1-artem.chernyshev@red-soft.ru Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
@@ -264,9 +264,7 @@ static int isci_register_sas_ha(struct isci_host *isci_host)
 
 	sas_ha->strict_wide_ports = 1;
 
-	sas_register_ha(sas_ha);
-
-	return 0;
+	return sas_register_ha(sas_ha);
 }
 
 static void isci_unregister(struct isci_host *isci_host)

Original file line number	Diff line number	Diff line change
`@@ -264,9 +264,7 @@ static int isci_register_sas_ha(struct isci_host *isci_host)`
`264`	`264`
`265`	`265`	`sas_ha->strict_wide_ports = 1;`
`266`	`266`
`267`		`- sas_register_ha(sas_ha);`
`268`		`-`
`269`		`- return 0;`
	`267`	`+ return sas_register_ha(sas_ha);`
`270`	`268`	`}`
`271`	`269`
`272`	`270`	`static void isci_unregister(struct isci_host *isci_host)`