Skip to content

Commit 8cf96b4

Browse files
asjkdave
authored andcommitted
btrfs: free btrfs_path before copying fspath to userspace
btrfs_ioctl_ino_to_path() frees the search path after the userspace copy from the temp buffer @ipath->fspath. Which potentially can lead to a lock splat warning. Fix this by freeing the path before we copy it to userspace. CC: stable@vger.kernel.org # 4.19+ Signed-off-by: Anand Jain <anand.jain@oracle.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 418ffb9 commit 8cf96b4

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

fs/btrfs/ioctl.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4232,6 +4232,8 @@ static long btrfs_ioctl_ino_to_path(struct btrfs_root *root, void __user *arg)
42324232
ipath->fspath->val[i] = rel_ptr;
42334233
}
42344234

4235+
btrfs_free_path(path);
4236+
path = NULL;
42354237
ret = copy_to_user((void __user *)(unsigned long)ipa->fspath,
42364238
ipath->fspath, size);
42374239
if (ret) {

0 commit comments

Comments
 (0)