Skip to content

Commit 8920157

Browse files
committed
auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Acked-by: Miguel Ojeda <ojeda@kernel.org> Cc: Miguel Ojeda <ojeda@kernel.org> Cc: Robin van der Gracht <robin@protonic.nl> Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-10-tzimmermann@suse.de
1 parent 0e00789 commit 8920157

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/auxdisplay/cfag12864bfb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ static int cfag12864bfb_probe(struct platform_device *device)
7979
info->var = cfag12864bfb_var;
8080
info->pseudo_palette = NULL;
8181
info->par = NULL;
82-
info->flags = FBINFO_FLAG_DEFAULT;
8382

8483
if (register_framebuffer(info) < 0)
8584
goto fballoced;

drivers/auxdisplay/ht16k33.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,6 @@ static int ht16k33_fbdev_probe(struct device *dev, struct ht16k33_priv *priv,
646646
fbdev->info->var = ht16k33_fb_var;
647647
fbdev->info->bl_dev = bl;
648648
fbdev->info->pseudo_palette = NULL;
649-
fbdev->info->flags = FBINFO_FLAG_DEFAULT;
650649
fbdev->info->par = priv;
651650

652651
err = register_framebuffer(fbdev->info);

0 commit comments

Comments
 (0)