Skip to content

Commit 8446f9d

Browse files
Dan Carpenterjwrdegoede
authored andcommitted
platform/x86: wmi: Fix wmi_dev_probe()
This has a reversed if statement so it accidentally disables the wmi method before returning. Fixes: 704af3a ("platform/x86: wmi: Remove chardev interface") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Armin Wolf <W_Armin@gmx.de> Link: https://lore.kernel.org/r/9c81251b-bc87-4ca3-bb86-843dc85e5145@moroto.mountain Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 29e473f commit 8446f9d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/platform/x86

drivers/platform/x86/wmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ static int wmi_dev_probe(struct device *dev)
896896
if (wdriver->probe) {
897897
ret = wdriver->probe(dev_to_wdev(dev),
898898
find_guid_context(wblock, wdriver));
899-
if (!ret) {
899+
if (ret) {
900900
if (ACPI_FAILURE(wmi_method_enable(wblock, false)))
901901
dev_warn(dev, "Failed to disable device\n");
902902

0 commit comments

Comments
 (0)