Skip to content

Commit 7fd71f3

Browse files
jbrandebanguy11
authored andcommitted
ice: fix reservation of resources for RDMA when disabled
If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a built-in, then don't let the driver reserve resources for RDMA. The result of this change is a large savings in resources for older kernels, and a cleaner driver configuration for the IRDMA=n case for old and new kernels. Implement this by avoiding enabling the RDMA capability when scanning hardware capabilities. Note: Loading the out-of-tree irdma driver in connection to the in-kernel ice driver, is not supported, and should not be attempted, especially when disabling IRDMA in the kernel config. Fixes: d25a0fc ("ice: Initialize RDMA support") Signed-off-by: Jesse Brandeburg <jbrandeburg@cloudflare.com> Acked-by: Dave Ertman <david.m.ertman@intel.com> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent 53ce716 commit 7fd71f3

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/net/ethernet/intel/ice/ice_common.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2271,7 +2271,8 @@ ice_parse_common_caps(struct ice_hw *hw, struct ice_hw_common_caps *caps,
22712271
caps->nvm_unified_update);
22722272
break;
22732273
case ICE_AQC_CAPS_RDMA:
2274-
caps->rdma = (number == 1);
2274+
if (IS_ENABLED(CONFIG_INFINIBAND_IRDMA))
2275+
caps->rdma = (number == 1);
22752276
ice_debug(hw, ICE_DBG_INIT, "%s: rdma = %d\n", prefix, caps->rdma);
22762277
break;
22772278
case ICE_AQC_CAPS_MAX_MTU:

0 commit comments

Comments
 (0)