Skip to content

Commit 711f9b8

Browse files
amir73ilbrauner
authored andcommitted
fsnotify: disable pre-content and permission events by default
After introducing pre-content events, we had a regression related to disabling huge faults on files that should never have pre-content events enabled. This happened because the default f_mode of allocated files (0) does not disable pre-content events. Pre-content events are disabled in file_set_fsnotify_mode_by_watchers() but internal files may not get to call this helper. Initialize f_mode to disable permission and pre-content events for all files and if needed they will be enabled for the callers of file_set_fsnotify_mode_by_watchers(). Fixes: 20bf82a ("mm: don't allow huge faults for files with pre content watches") Reported-by: Alex Williamson <alex.williamson@redhat.com> Closes: https://lore.kernel.org/linux-fsdevel/20250131121703.1e4d00a7.alex.williamson@redhat.com/ Tested-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Link: https://lore.kernel.org/r/20250203223205.861346-4-amir73il@gmail.com Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 2a42754 commit 711f9b8

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

fs/file_table.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,11 @@ static int init_file(struct file *f, int flags, const struct cred *cred)
194194
* refcount bumps we should reinitialize the reused file first.
195195
*/
196196
file_ref_init(&f->f_ref, 1);
197+
/*
198+
* Disable permission and pre-content events for all files by default.
199+
* They may be enabled later by file_set_fsnotify_mode_from_watchers().
200+
*/
201+
file_set_fsnotify_mode(f, FMODE_NONOTIFY_PERM);
197202
return 0;
198203
}
199204

0 commit comments

Comments
 (0)