leds: lm3601x: Reset LED controller during probe

zenghuchen-gg · lag-linaro · commit 70a4375e07fc · 2024-08-05T15:15:27.000+01:00
LED controller should be reset during initialization to avoid abnormal behaviors. For example, when power to SoC is recycled but power to LED controller is not, LED controller should not presume to be in original state. Signed-off-by: Jack Chen <zenghuchen@google.com> Link: https://lore.kernel.org/r/20240801153048.3813581-1-zenghuchen@google.com Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/leds/flash/leds-lm3601x.c b/drivers/leds/flash/leds-lm3601x.c
@@ -443,6 +443,10 @@ static int lm3601x_probe(struct i2c_client *client)
 		return ret;
 	}
 
+	ret = regmap_write(led->regmap, LM3601X_DEV_ID_REG, LM3601X_SW_RESET);
+	if (ret)
+		dev_warn(&client->dev, "Failed to reset the LED controller\n");
+
 	mutex_init(&led->lock);
 
 	return lm3601x_register_leds(led, fwnode);

Original file line number	Diff line number	Diff line change
`@@ -443,6 +443,10 @@ static int lm3601x_probe(struct i2c_client *client)`
`443`	`443`	`return ret;`
`444`	`444`	`}`
`445`	`445`
	`446`	`+ ret = regmap_write(led->regmap, LM3601X_DEV_ID_REG, LM3601X_SW_RESET);`
	`447`	`+ if (ret)`
	`448`	`+ dev_warn(&client->dev, "Failed to reset the LED controller\n");`
	`449`	`+`
`446`	`450`	`mutex_init(&led->lock);`
`447`	`451`
`448`	`452`	`return lm3601x_register_leds(led, fwnode);`