Skip to content

Commit 7010357

Browse files
Dawei Lismfrench
authored andcommitted
ksmbd: Remove duplicated codes
ksmbd_neg_token_init_mech_token() and ksmbd_neg_token_targ_resp_token() share same implementation, unify them. Signed-off-by: Dawei Li <set_pte_at@outlook.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent f8d6e74 commit 7010357

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

fs/ksmbd/asn1.c

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,9 @@ int ksmbd_neg_token_init_mech_type(void *context, size_t hdrlen,
208208
return 0;
209209
}
210210

211-
int ksmbd_neg_token_init_mech_token(void *context, size_t hdrlen,
212-
unsigned char tag, const void *value,
213-
size_t vlen)
211+
static int ksmbd_neg_token_alloc(void *context, size_t hdrlen,
212+
unsigned char tag, const void *value,
213+
size_t vlen)
214214
{
215215
struct ksmbd_conn *conn = context;
216216

@@ -223,17 +223,16 @@ int ksmbd_neg_token_init_mech_token(void *context, size_t hdrlen,
223223
return 0;
224224
}
225225

226-
int ksmbd_neg_token_targ_resp_token(void *context, size_t hdrlen,
226+
int ksmbd_neg_token_init_mech_token(void *context, size_t hdrlen,
227227
unsigned char tag, const void *value,
228228
size_t vlen)
229229
{
230-
struct ksmbd_conn *conn = context;
231-
232-
conn->mechToken = kmalloc(vlen + 1, GFP_KERNEL);
233-
if (!conn->mechToken)
234-
return -ENOMEM;
230+
return ksmbd_neg_token_alloc(context, hdrlen, tag, value, vlen);
231+
}
235232

236-
memcpy(conn->mechToken, value, vlen);
237-
conn->mechToken[vlen] = '\0';
238-
return 0;
233+
int ksmbd_neg_token_targ_resp_token(void *context, size_t hdrlen,
234+
unsigned char tag, const void *value,
235+
size_t vlen)
236+
{
237+
return ksmbd_neg_token_alloc(context, hdrlen, tag, value, vlen);
239238
}

0 commit comments

Comments
 (0)