Skip to content

Commit 6b023c7

Browse files
jpoimboeingomolnar
authored andcommitted
objtool: Silence more KCOV warnings
In the past there were issues with KCOV triggering unreachable instruction warnings, which is why unreachable warnings are now disabled with CONFIG_KCOV. Now some new KCOV warnings are showing up with GCC 14: vmlinux.o: warning: objtool: cpuset_write_resmask() falls through to next function cpuset_update_active_cpus.cold() drivers/usb/core/driver.o: error: objtool: usb_deregister() falls through to next function usb_match_device() sound/soc/codecs/snd-soc-wcd934x.o: warning: objtool: .text.wcd934x_slim_irq_handler: unexpected end of section All are caused by GCC KCOV not finishing an optimization, leaving behind a never-taken conditional branch to a basic block which falls through to the next function (or end of section). At a high level this is similar to the unreachable warnings mentioned above, in that KCOV isn't fully removing dead code. Treat it the same way by adding these to the list of warnings to ignore with CONFIG_KCOV. Reported-by: Ingo Molnar <mingo@kernel.org> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Link: https://lore.kernel.org/r/66a61a0b65d74e072d3dc02384e395edb2adc3c5.1742852846.git.jpoimboe@kernel.org Closes: https://lore.kernel.org/Z9iTsI09AEBlxlHC@gmail.com Closes: https://lore.kernel.org/oe-kbuild-all/202503180044.oH9gyPeg-lkp@intel.com/
1 parent 4fab2d7 commit 6b023c7

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

tools/objtool/check.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3485,6 +3485,9 @@ static int validate_branch(struct objtool_file *file, struct symbol *func,
34853485
!strncmp(func->name, "__pfx_", 6))
34863486
return 0;
34873487

3488+
if (file->ignore_unreachables)
3489+
return 0;
3490+
34883491
WARN("%s() falls through to next function %s()",
34893492
func->name, insn_func(insn)->name);
34903493
return 1;
@@ -3694,6 +3697,9 @@ static int validate_branch(struct objtool_file *file, struct symbol *func,
36943697
if (!next_insn) {
36953698
if (state.cfi.cfa.base == CFI_UNDEFINED)
36963699
return 0;
3700+
if (file->ignore_unreachables)
3701+
return 0;
3702+
36973703
WARN("%s: unexpected end of section", sec->name);
36983704
return 1;
36993705
}

0 commit comments

Comments
 (0)