Skip to content

Commit 5deff02

Browse files
opanait-wrherbertx
authored andcommitted
crypto: sahara - improve error handling in sahara_sha_process()
sahara_sha_hw_data_descriptor_create() returns negative error codes on failure, so make sure the errors are correctly handled / propagated. Fixes: 5a2bb93 ("crypto: sahara - add support for SHA1/256") Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 2dba8e1 commit 5deff02

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

drivers/crypto/sahara.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -985,15 +985,21 @@ static int sahara_sha_process(struct ahash_request *req)
985985
return ret;
986986

987987
if (rctx->first) {
988-
sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0);
988+
ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0);
989+
if (ret)
990+
return ret;
991+
989992
dev->hw_desc[0]->next = 0;
990993
rctx->first = 0;
991994
} else {
992995
memcpy(dev->context_base, rctx->context, rctx->context_size);
993996

994997
sahara_sha_hw_context_descriptor_create(dev, rctx, req, 0);
995998
dev->hw_desc[0]->next = dev->hw_phys_desc[1];
996-
sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1);
999+
ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1);
1000+
if (ret)
1001+
return ret;
1002+
9971003
dev->hw_desc[1]->next = 0;
9981004
}
9991005

0 commit comments

Comments
 (0)