drm/amdgpu: Fix a memory leak

Luben Tuikov · alexdeucher · commit 5d061675b753 · 2023-10-04T22:43:26.000-04:00
Fix a memory leak in amdgpu_fru_get_product_info(). Cc: Alex Deucher <Alexander.Deucher@amd.com> Reported-by: Yang Wang <kevinyang.wang@amd.com> Fixes: 0dbf2c5 ("drm/amdgpu: Interpret IPMI data for product information (v2)") Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> Reviewed-by: Alex Deucher <Alexander.Deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
@@ -170,6 +170,7 @@ int amdgpu_fru_get_product_info(struct amdgpu_device *adev)
 		csum += pia[size - 1];
 	if (csum) {
 		DRM_ERROR("Bad Product Info Area checksum: 0x%02x", csum);
+		kfree(pia);
 		return -EIO;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,7 @@ int amdgpu_fru_get_product_info(struct amdgpu_device *adev)`
`170`	`170`	`csum += pia[size - 1];`
`171`	`171`	`if (csum) {`
`172`	`172`	`DRM_ERROR("Bad Product Info Area checksum: 0x%02x", csum);`
	`173`	`+ kfree(pia);`
`173`	`174`	`return -EIO;`
`174`	`175`	`}`
`175`	`176`