drm/xe/hwmon: Fix WRITE_I1 param from u32 to u16

kpoosa · rodrigovivi · commit 59d237c8a241 · 2024-08-29T09:44:00.000-04:00
WRITE_I1 sub-command of the POWER_SETUP pcode command accepts a u16 parameter instead of u32. This change prevents potential illegal sub-command errors. v2: Mask uval instead of changing the prototype. (Badal) v3: Rephrase commit message. (Badal) Signed-off-by: Karthik Poosa <karthik.poosa@intel.com> Fixes: 92d44a4 ("drm/xe/hwmon: Expose card reactive critical power") Reviewed-by: Badal Nilawar <badal.nilawar@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240827155301.183383-1-karthik.poosa@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (cherry picked from commit a7f6570) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -450,7 +450,7 @@ static int xe_hwmon_pcode_write_i1(struct xe_gt *gt, u32 uval)
 {
 	return xe_pcode_write(gt, PCODE_MBOX(PCODE_POWER_SETUP,
 			      POWER_SETUP_SUBCOMMAND_WRITE_I1, 0),
-			      uval);
+			      (uval & POWER_SETUP_I1_DATA_MASK));
 }
 
 static int xe_hwmon_power_curr_crit_read(struct xe_hwmon *hwmon, int channel,

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,7 @@ static int xe_hwmon_pcode_write_i1(struct xe_gt *gt, u32 uval)`
`450`	`450`	`{`
`451`	`451`	`return xe_pcode_write(gt, PCODE_MBOX(PCODE_POWER_SETUP,`
`452`	`452`	`POWER_SETUP_SUBCOMMAND_WRITE_I1, 0),`
`453`		`- uval);`
	`453`	`+ (uval & POWER_SETUP_I1_DATA_MASK));`
`454`	`454`	`}`
`455`	`455`
`456`	`456`	`static int xe_hwmon_power_curr_crit_read(struct xe_hwmon *hwmon, int channel,`