Skip to content

Commit 5335aff

Browse files
Darrick J. WongChandan Babu R
authored andcommitted
xfs: fix folio dirtying for XFILE_ALLOC callers
willy pointed out that folio_mark_dirty is the correct function to use to mark an xfile folio dirty because it calls out to the mapping's aops to mark it dirty. For tmpfs this likely doesn't matter much since it currently uses nop_dirty_folio, but let's use the abstractions properly. Reported-by: willy@infradead.org Fixes: 6907e3c ("xfs: add file_{get,put}_folio") Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
1 parent e21fea4 commit 5335aff

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/xfs/scrub/xfile.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ xfile_get_folio(
293293
* (potentially last) reference in xfile_put_folio.
294294
*/
295295
if (flags & XFILE_ALLOC)
296-
folio_set_dirty(folio);
296+
folio_mark_dirty(folio);
297297
return folio;
298298
}
299299

0 commit comments

Comments
 (0)