f2fs: Remove f2fs_write_meta_page()

Matthew Wilcox (Oracle) · Jaegeuk Kim · commit 3b47398d9861 · 2025-03-11T19:37:57.000Z
Mappings which implement writepages should not implement writepage
as it can only harm writeback patterns.

Signed-off-by: Matthew Wilcox (Oracle) &lt;willy@infradead.org&gt;
Reviewed-by: Chao Yu &lt;chao@kernel.org&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
@@ -381,12 +381,6 @@ static int __f2fs_write_meta_page(struct page *page,
 	return AOP_WRITEPAGE_ACTIVATE;
 }
 
-static int f2fs_write_meta_page(struct page *page,
-				struct writeback_control *wbc)
-{
-	return __f2fs_write_meta_page(page, wbc, FS_META_IO);
-}
-
 static int f2fs_write_meta_pages(struct address_space *mapping,
 				struct writeback_control *wbc)
 {
@@ -507,7 +501,6 @@ static bool f2fs_dirty_meta_folio(struct address_space *mapping,
 }
 
 const struct address_space_operations f2fs_meta_aops = {
-	.writepage	= f2fs_write_meta_page,
 	.writepages	= f2fs_write_meta_pages,
 	.dirty_folio	= f2fs_dirty_meta_folio,
 	.invalidate_folio = f2fs_invalidate_folio,

Original file line number	Diff line number	Diff line change
`@@ -381,12 +381,6 @@ static int __f2fs_write_meta_page(struct page *page,`
`381`	`381`	`return AOP_WRITEPAGE_ACTIVATE;`
`382`	`382`	`}`
`383`	`383`
`384`		`-static int f2fs_write_meta_page(struct page *page,`
`385`		`- struct writeback_control *wbc)`
`386`		`-{`
`387`		`- return __f2fs_write_meta_page(page, wbc, FS_META_IO);`
`388`		`-}`
`389`		`-`
`390`	`384`	`static int f2fs_write_meta_pages(struct address_space *mapping,`
`391`	`385`	`struct writeback_control *wbc)`
`392`	`386`	`{`
`@@ -507,7 +501,6 @@ static bool f2fs_dirty_meta_folio(struct address_space *mapping,`
`507`	`501`	`}`
`508`	`502`
`509`	`503`	`const struct address_space_operations f2fs_meta_aops = {`
`510`		`- .writepage = f2fs_write_meta_page,`
`511`	`504`	`.writepages = f2fs_write_meta_pages,`
`512`	`505`	`.dirty_folio = f2fs_dirty_meta_folio,`
`513`	`506`	`.invalidate_folio = f2fs_invalidate_folio,`