Skip to content

Commit 37551b4

Browse files
Dan Carpenterkuba-moo
authored andcommitted
rtase: Fix error code in rtase_init_board()
Return an error if dma_set_mask_and_coherent() fails. Don't return success. Fixes: a36e9f5 ("rtase: Add support for a pci table in this module") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/f53ed942-5ac2-424b-a1ed-9473c599905e@stanley.mountain Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 1b8c9cb commit 37551b4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/net/ethernet/realtek/rtase/rtase_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2023,7 +2023,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
20232023
if (ret < 0)
20242024
goto err_out_disable;
20252025

2026-
if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
2026+
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
2027+
if (ret) {
20272028
dev_err(&pdev->dev, "no usable dma addressing method\n");
20282029
goto err_out_free_res;
20292030
}

0 commit comments

Comments
 (0)