xfs: remove unnecessary NULL check before kvfree()

Chen Ni · cmaiolino · commit 34ba1fcd7456 · 2025-03-18T14:24:13.000+01:00
Remove unnecessary NULL check before kvfree() reported by
Coccinelle/coccicheck and the semantic patch at
scripts/coccinelle/free/ifnullfree.cocci.

Signed-off-by: Chen Ni &lt;nichen@iscas.ac.cn&gt;
Reviewed-by: Carlos Maiolino &lt;cmaiolino@redhat.com&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Carlos Maiolino &lt;cem@kernel.org&gt;
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
@@ -1212,8 +1212,7 @@ xfs_growfs_rtg(
 			goto out_error;
 	}
 
-	if (old_rsum_cache)
-		kvfree(old_rsum_cache);
+	kvfree(old_rsum_cache);
 	goto out_rele;
 
 out_error:

Original file line number	Diff line number	Diff line change
`@@ -1212,8 +1212,7 @@ xfs_growfs_rtg(`
`1212`	`1212`	`goto out_error;`
`1213`	`1213`	`}`
`1214`	`1214`
`1215`		`- if (old_rsum_cache)`
`1216`		`- kvfree(old_rsum_cache);`
	`1215`	`+ kvfree(old_rsum_cache);`
`1217`	`1216`	`goto out_rele;`
`1218`	`1217`
`1219`	`1218`	`out_error:`