SUNRPC: rpcbind should never reset the port to the value '0'

Trond Myklebust · Trond Myklebust · commit 214c13e380ad · 2025-03-26T12:17:38.000-04:00
If we already had a valid port number for the RPC service, then we
should not allow the rpcbind client to set it to the invalid value '0'.

Reviewed-by: Jeff Layton &lt;jlayton@kernel.org&gt;
Reviewed-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
@@ -820,9 +820,10 @@ static void rpcb_getport_done(struct rpc_task *child, void *data)
 	}
 
 	trace_rpcb_setport(child, map->r_status, map->r_port);
-	xprt->ops->set_port(xprt, map->r_port);
-	if (map->r_port)
+	if (map->r_port) {
+		xprt->ops->set_port(xprt, map->r_port);
 		xprt_set_bound(xprt);
+	}
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -820,9 +820,10 @@ static void rpcb_getport_done(struct rpc_task child, void data)`
`820`	`820`	`}`
`821`	`821`
`822`	`822`	`trace_rpcb_setport(child, map->r_status, map->r_port);`
`823`		`- xprt->ops->set_port(xprt, map->r_port);`
`824`		`- if (map->r_port)`
	`823`	`+ if (map->r_port) {`
	`824`	`+ xprt->ops->set_port(xprt, map->r_port);`
`825`	`825`	`xprt_set_bound(xprt);`
	`826`	`+ }`
`826`	`827`	`}`
`827`	`828`
`828`	`829`	`/*`