Skip to content

Commit 1fe4f1b

Browse files
hkallweitlag-linaro
authored andcommitted
leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate
led_trigger_set() is the only caller of the deactivate() callback, and it calls led_set_brightness(LED_OFF) anyway after deactivate(). So we can remove the call here. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Link: https://lore.kernel.org/r/8dc929e7-8e14-4c85-aa28-9c5fe2620f52@gmail.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 77b9f2d commit 1fe4f1b

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/leds/trigger/ledtrig-netdev.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -724,8 +724,6 @@ static void netdev_trig_deactivate(struct led_classdev *led_cdev)
724724

725725
cancel_delayed_work_sync(&trigger_data->work);
726726

727-
led_set_brightness(led_cdev, LED_OFF);
728-
729727
dev_put(trigger_data->net_dev);
730728

731729
kfree(trigger_data);

0 commit comments

Comments
 (0)