accel/amdxdna: Use rcu_access_pointer for __rcu pointer

houlz0507 · superm1 · commit 1f7440052948 · 2025-01-03T23:38:13.000-06:00
Use rcu_access_pointer for pid in struct drm_file. This fixes sparse warning. Fixes: be462c9 ("accel/amdxdna: Add hardware context") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412311210.LfeHTzLw-lkp@intel.com/ Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250102212244.1586340-4-lizhi.hou@amd.com
diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.c b/drivers/accel/amdxdna/amdxdna_pci_drv.c
@@ -61,7 +61,7 @@ static int amdxdna_drm_open(struct drm_device *ddev, struct drm_file *filp)
 		goto put_rpm;
 	}
 
-	client->pid = pid_nr(filp->pid);
+	client->pid = pid_nr(rcu_access_pointer(filp->pid));
 	client->xdna = xdna;
 
 	client->sva = iommu_sva_bind_device(xdna->ddev.dev, current->mm);

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ static int amdxdna_drm_open(struct drm_device ddev, struct drm_file filp)`
`61`	`61`	`goto put_rpm;`
`62`	`62`	`}`
`63`	`63`
`64`		`- client->pid = pid_nr(filp->pid);`
	`64`	`+ client->pid = pid_nr(rcu_access_pointer(filp->pid));`
`65`	`65`	`client->xdna = xdna;`
`66`	`66`
`67`	`67`	`client->sva = iommu_sva_bind_device(xdna->ddev.dev, current->mm);`