platform/x86: think-lmi: Use kfree_sensitive instead of kfree

Wang Ming · jwrdegoede · commit 1da0893aed2e · 2023-07-25T15:30:57.000+02:00
key might contain private part of the key, so better use kfree_sensitive to free it. Signed-off-by: Wang Ming <machel@vivo.com> Link: https://lore.kernel.org/r/20230717101114.18966-1-machel@vivo.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
@@ -719,12 +719,12 @@ static ssize_t cert_to_password_store(struct kobject *kobj,
 	/* Format: 'Password,Signature' */
 	auth_str = kasprintf(GFP_KERNEL, "%s,%s", passwd, setting->signature);
 	if (!auth_str) {
-		kfree(passwd);
+		kfree_sensitive(passwd);
 		return -ENOMEM;
 	}
 	ret = tlmi_simple_call(LENOVO_CERT_TO_PASSWORD_GUID, auth_str);
 	kfree(auth_str);
-	kfree(passwd);
+	kfree_sensitive(passwd);
 
 	return ret ?: count;
 }

Original file line number	Diff line number	Diff line change
`@@ -719,12 +719,12 @@ static ssize_t cert_to_password_store(struct kobject *kobj,`
`719`	`719`	`/* Format: 'Password,Signature' */`
`720`	`720`	`auth_str = kasprintf(GFP_KERNEL, "%s,%s", passwd, setting->signature);`
`721`	`721`	`if (!auth_str) {`
`722`		`- kfree(passwd);`
	`722`	`+ kfree_sensitive(passwd);`
`723`	`723`	`return -ENOMEM;`
`724`	`724`	`}`
`725`	`725`	`ret = tlmi_simple_call(LENOVO_CERT_TO_PASSWORD_GUID, auth_str);`
`726`	`726`	`kfree(auth_str);`
`727`		`- kfree(passwd);`
	`727`	`+ kfree_sensitive(passwd);`
`728`	`728`
`729`	`729`	`return ret ?: count;`
`730`	`730`	`}`