Skip to content

Commit 1898714

Browse files
bvanasschemartinkpetersen
authored andcommitted
scsi: ufs: core: Remove an unnecessary NULL pointer check
The !payload check tests the address of a member of a data structure. We know that the start address of this data structure (job) is not NULL since the 'job' pointer has already been dereferenced. Hence, the !payload check is superfluous. Remove this test. This was reported by the CodeSonar static analyzer. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Link: https://patch.msgid.link/20251111184802.125111-1-bvanassche@acm.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 1028258 commit 1898714

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/ufs/core/ufs_bsg.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ static int ufs_bsg_exec_advanced_rpmb_req(struct ufs_hba *hba, struct bsg_job *j
105105

106106
if (dir != DMA_NONE) {
107107
payload = &job->request_payload;
108-
if (!payload || !payload->payload_len || !payload->sg_cnt)
108+
if (!payload->payload_len || !payload->sg_cnt)
109109
return -EINVAL;
110110

111111
sg_cnt = dma_map_sg(hba->host->dma_dev, payload->sg_list, payload->sg_cnt, dir);

0 commit comments

Comments
 (0)