Test fixes — safety first STOP if not in test mode

Author: bnmnetp

components/rsptx/db/async_session.py

@@ -56,7 +56,7 @@
 # Generate this key once and store it securely (e.g., env var or config file)
 fernet = Fernet(settings.fernet_secret)
 
-
+import pdb
 async def init_models():
     async with engine.begin() as conn:
         # Never, ever drop tables in a production environment!
@@ -65,6 +65,7 @@ async def init_models():
             in [BookServerConfig.development, BookServerConfig.test]
             and settings.drop_tables == "Yes"
         ):
+            pdb.set_trace()
             await conn.run_sync(Base.metadata.drop_all)
         await conn.run_sync(Base.metadata.create_all)
 

components/rsptx/db/models.py

@@ -530,13 +530,20 @@ class AuthGroup(Base, IdMixin):
 
     role = Column(String(512))
     description = Column(Text)
+    memberships = relationship(
+        "AuthMembership",
+        back_populates="group",
+        cascade="all, delete-orphan",
+        passive_deletes=True,
+    )
 
 
 class AuthMembership(Base, IdMixin):
     __tablename__ = "auth_membership"
 
     user_id = Column(ForeignKey("auth_user.id", ondelete="CASCADE"))
     group_id = Column(ForeignKey("auth_group.id", ondelete="CASCADE"))
+    group = relationship("AuthGroup", back_populates="memberships")
 
 
 class CourseInstructor(Base, IdMixin):

test/conftest.py

@@ -15,7 +15,11 @@
 
 def pytest_configure(config):
     """Set test environment variables before any rsptx modules are imported."""
-    os.environ.setdefault("SERVER_CONFIG", "test")
+    server_config = os.environ.setdefault("SERVER_CONFIG", "test")
+    if server_config != "test":
+        raise RuntimeError(
+            f"SERVER_CONFIG is set to '{server_config}', but must be 'test' for the test suite."
+        )
     os.environ.setdefault(
         "TEST_DBURL",
         "postgresql://runestone:runestone@localhost:2345/runestone_test",