Skip to content

Commit 58e7087

Browse files
committed
isse-1143 ensure minimum activities in ActivitiesRequiredCell component
1 parent e152918 commit 58e7087

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

  • bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/components/reading/components

bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/components/reading/components/ActivitiesRequiredCell.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,20 @@ interface ActivitiesRequiredCellProps {
1111
itemId: number;
1212
}
1313

14+
const MIN_ACTIVITIES = 1;
15+
1416
export const ActivitiesRequiredCell = ({
1517
value,
1618
exercise,
1719
onUpdate,
1820
itemId
1921
}: ActivitiesRequiredCellProps) => {
2022
const { showToast } = useToastContext();
21-
const [currentValue, setCurrentValue] = useState(value || 0);
23+
const [currentValue, setCurrentValue] = useState(value || MIN_ACTIVITIES);
2224

2325
const handleValueChange = (newValue: number | null | undefined) => {
24-
const numValue = newValue ?? 0;
25-
const activityCount = exercise.numQuestions || 0;
26+
const numValue = newValue ?? MIN_ACTIVITIES;
27+
const activityCount = exercise.numQuestions || MIN_ACTIVITIES;
2628

2729
if (numValue > activityCount) {
2830
showToast({
@@ -31,7 +33,7 @@ export const ActivitiesRequiredCell = ({
3133
detail: `# required (${numValue}) must not exceed the activity count (${activityCount}).`
3234
});
3335

34-
setCurrentValue(value || 0);
36+
setCurrentValue(value || MIN_ACTIVITIES);
3537
return;
3638
}
3739

@@ -43,8 +45,8 @@ export const ActivitiesRequiredCell = ({
4345
<InputNumber
4446
value={currentValue}
4547
onValueChange={(e) => handleValueChange(e.value)}
46-
min={0}
47-
max={exercise.numQuestions || 0}
48+
min={MIN_ACTIVITIES}
49+
max={exercise.numQuestions || MIN_ACTIVITIES}
4850
showButtons={false}
4951
style={{
5052
width: "100%",

0 commit comments

Comments
 (0)