lock student flow order

Author: sethbern

bases/rsptx/web2py_server/applications/runestone/controllers/peer.py

@@ -17,7 +17,7 @@
 import random
 import re
 import datetime
-
+import requests
 
 # Third Party
 # -----------
@@ -848,28 +848,27 @@ def get_async_llm_reflection():
         "you are a student talking to another student during peer instruction.\n"
         "you are both looking at the same multiple choice question with code and answers.\n"
         "you remember the code and choices.\n"
-        "most messages should be short (1 to 3 sentences, often very short).\n"
+        "most messages should be short (1 to 3 sentences often very short).\n"
         "use casual informal language and common typos.\n"
-        "sometimes use words.\n"
         "never use commas.\n"
         "never use gendered language.\n"
         "do not use new lines.\n"
         "do not sound like a teacher.\n"
         "do not explain step by step.\n"
         "do not mention libraries formally.\n"
         "never say something is right or wrong.\n"
-        "never mention a choice letter as the correct answer (like 'c is right' or 'probably b').\n"
+        "never mention a choice letter as the correct answer.\n"
         "never clearly describe the final result of the code.\n"
         "never fully state what the program prints.\n"
         "keep reasoning partial or uncertain.\n"
-        "if the other student clearly states confidence or repeats the same answer twice, stop debating and directly tell them to vote again.\n"
-        "do not continue reasoning after telling them to vote again.\n"
         "use common misconceptions and focus on only one part of the code.\n"
-        "refer to code loosely (like 'that line', 'the loop', 'the head', 'the print').\n"
+        "refer to code loosely like 'that line' or 'the loop' or 'the head' or 'the print'.\n"
         "often hedge with uncertainty.\n"
         "never agree with the other student's interpretation even if it sounds correct.\n"
+        "use content from the other multiple choice options in your reponses when needed\n"
         "maintain a mistaken or incomplete mental model throughout the conversation.\n"
-        "if the other student sounds confident or if they are not changing their perspective, tell them to vote again.\n"
+        "if the other student clearly sounds confident or repeats the same answer twice stop debating and tell them to vote again or submit it.\n"
+        "do not continue reasoning after telling them to vote again.\n"
         "focus on reasoning not teaching.\n\n"
     )
 
@@ -1011,22 +1010,6 @@ def send_lti_scores():
 
 
 
-
-
-import os, json
-import requests
-
-# --- helper to sanitize long, messy text we include in prompts ---
-def clean_text(s):
-    try:
-        s = s or ""
-        s = str(s)
-        # collapse whitespace per-line, avoid huge payloads
-        s = "\n".join(line.strip() for line in s.splitlines())
-        return s[:2000]
-    except Exception:
-        return ""
-
 def _get_umgpt_settings():
     api_key = os.environ.get("UMGPT_API_KEY", "").strip()
     base_url = os.environ.get("UMGPT_BASE_URL", "").strip()
@@ -1066,76 +1049,4 @@ def _call_openai(messages):
     )
     resp.raise_for_status()
     data = resp.json()
-    return data["choices"][0]["message"]["content"].strip()
-
-def get_gpt_response():
-    """
-
-    GET ?message=...  -> echo mode
-    POST JSON {"messages":[...]} -> calls UMGPT if UMGPT_* config is set, else stub
-    """
-    if request.env.request_method == "GET":
-        msg = request.vars.message or ""
-        return response.json(dict(ok=True, echo=msg, reply="(echo) " + msg, tokens_used=0))
-
-    try:
-        raw = request.body.read().decode("utf-8")
-    except Exception:
-        raw = "{}"
-
-    try:
-        payload = json.loads(raw or "{}")
-    except Exception:
-        payload = {}
-
-    messages = payload.get("messages", [])
-    context = payload.get("context") or {}
-
-    messages_with_context = messages
-    try:
-        if isinstance(context, dict) and context.get("ok") is True:
-            course = context.get("course")
-            basecourse = context.get("basecourse")
-            username = context.get("username")
-            comp_id = context.get("id")
-            comp_type = context.get("type")
-            prompt_txt = clean_text(context.get("prompt"))
-            code_txt = clean_text(context.get("code"))
-            choices = context.get("choices") or []
-            selected = context.get("selected")
-            out_txt = clean_text(context.get("output"))
-            err_txt = clean_text(context.get("error"))
-            coach_txt = clean_text(context.get("coach"))
-
-            sys_ctx = (
-                "You are a friendly peer in a Runestone ebook helping with the CURRENT exercise. "
-                "Be concise, guide reasoning, and avoid giving full solutions. If the user asks 'what is this asking me to do', "
-                "summarize the task in plain language, then suggest first steps.\n\n"
-                f"Course: {course} | Basecourse: {basecourse} | User: {username}\n"
-                f"Component: {comp_type} | ID: {comp_id}\n"
-                f"Prompt:\n{prompt_txt}\n\n"
-                + (f"Starter/Current Code:\n{code_txt}\n\n" if code_txt else "")
-                + ("Choices:\n- " + "\n- ".join(map(str, choices)) + (f"\n\nSelected: {selected}" if selected else "") + "\n\n" if choices else "")
-                + (f"Last Run Output:\n{out_txt}\n\n" if out_txt else "")
-                + (f"Last Run Error:\n{err_txt}\n\n" if err_txt else "")
-                + (f"Coach/Guidance:\n{coach_txt}\n\n" if coach_txt else "")
-                + "Rules: Never reveal solutions verbatim. Encourage peer-instruction style hints."
-            )
-
-            messages_with_context = [{"role": "system", "content": sys_ctx}] + messages
-    except Exception:
-        messages_with_context = messages
-    if not isinstance(messages, list) or not messages:
-        return response.json(dict(ok=False, error="messages[] required"))
-
-    try:
-        reply = _call_openai(messages_with_context)
-        if reply is None:
-            user_last = next((m.get("content","") for m in reversed(messages) if m.get("role")=="user"), "")
-            reply = f"(stub) Here is how to think about it: {user_last}"
-        return response.json(dict(ok=True, reply=reply, tokens_used=0))
-    except requests.HTTPError as e:
-        return response.json(dict(ok=False, error=f"HTTP {e.response.status_code}: {e.response.text[:200]}"))
-    except Exception as e:
-        return response.json(dict(ok=False, error=str(e)[:200]))
-    
+    return data["choices"][0]["message"]["content"].strip()

bases/rsptx/web2py_server/applications/runestone/views/peer/peer_async.html

@@ -21,12 +21,12 @@
 eBookConfig.host = window.location.origin;
 eBookConfig.isLoggedIn = true;
 </script> -->
-
+<!-- 
 {{ if has_vote1: }}
   <p><em>Vote 1 detected</em></p>
 {{ else: }}
   <p><em>No vote yet</em></p>
-{{ pass }}
+{{ pass }} -->
 <div id="peer_async_root" data-div_id="{{=current_question.name}}">
 </div>
 
@@ -141,32 +141,61 @@ <h3>Congratulations, you have completed this assignment!</h3>
 <script src="/runestone/static/js/peer.js?v={{=request.peer_mtime}}"></script>
 <script>
   window._vote2Enabled = false;
+  window._vote1Locked = false;
+
+  function setVoteInputsLocked(locked) {
+    try {
+      const comp = window.componentMap[currentQuestion];
+      if (comp && comp.submitButton) {
+        comp.submitButton.disabled = locked;
+      }
+      if (comp && typeof comp.disableInteraction === "function" && locked) {
+        comp.disableInteraction();
+      }
+      if (comp && typeof comp.enableInteraction === "function" && !locked) {
+        comp.enableInteraction();
+      }
+    } catch (e) {
+      console.warn("vote lock toggle failed", e);
+    }
+  }
+
+  function lockVote1AndReflection() {
+    window._vote1Locked = true;
+    setVoteInputsLocked(true);
+    const ta = document.getElementById("messageText");
+    const btn = document.getElementById("submitReflection");
+    if (ta) ta.disabled = true;
+    if (btn) btn.disabled = true;
+  }
+
+  function setReflectionPanelEnabled(enabled) {
+    const panel = document.getElementById("reflectionPanel");
+    if (!panel) return;
+    panel.style.opacity = enabled ? "1" : "0.5";
+    panel.style.pointerEvents = enabled ? "auto" : "none";
+    if (enabled) {
+      const notice = document.getElementById("vote1Notice");
+      if (notice) notice.remove();
+    }
+  }
 
   function enableSecondVoteAsync() {
     console.log("PI async: enabling vote 2");
-    if (!window._vote2Enabled && studentVoteCount < 1) {
+    if (!hasVote1) {
       alert("Please submit your first vote before voting again.");
       return;
     }
 
     window._vote2Enabled = true;
+    window._vote1Locked = false;
 
     studentSubmittedVote2 = false;
     if (typeof studentVoteCount !== "undefined" && studentVoteCount < 2) {
       studentVoteCount = 2;
     }
 
-    try {
-      const comp = window.componentMap[currentQuestion];
-      comp.submitButton.disabled = false;
-
-      const root = document.getElementById(currentQuestion);
-      root?.querySelectorAll("input, button").forEach(el => {
-        el.disabled = false;
-      });
-    } catch (e) {
-      console.warn("vote 2 enable fallback failed", e);
-    }
+    setVoteInputsLocked(false);
 
     const b = document.getElementById("readyVote2Btn");
     if (b) b.style.display = "none";
@@ -205,10 +234,13 @@ <h3>Congratulations, you have completed this assignment!</h3>
   const nextStepEl = document.getElementById("nextStep");
 
   btn.addEventListener("click", async function () {
-  if (studentVoteCount < 1) {
+  if (!hasVote1) {
     alert("Please submit your first vote before starting the discussion.");
     return;
   }
+  if (window._vote1Locked) {
+    return;
+  }
 
   const reflection = (ta.value || "").trim();
   if (!reflection) {
@@ -258,6 +290,7 @@ <h3>Congratulations, you have completed this assignment!</h3>
   const discussion = document.getElementById("llmDiscussion");
   const chat = document.getElementById("llmChat");
   const nextStep = document.getElementById("nextStep");
+  lockVote1AndReflection();
 
   discussion.style.display = "block";
   chat.innerHTML = "<p><em>Thinking about your explanation…</em></p>";
@@ -434,7 +467,8 @@ <h3>Congratulations, you have completed this assignment!</h3>
         setTimeout(connect, 1000);
     });
     var studentVoteCount = 1;
-    var hasVote1 = false;
+    var hasVote1 = {{='true' if has_vote1 else 'false'}};
+    var hasReflection = {{='true' if has_reflection else 'false'}};
     var studentSubmittedVote2 = false;
     var vote2done = false;
     var llmUserMessageCount = 0;
@@ -469,18 +503,31 @@ <h3>Congratulations, you have completed this assignment!</h3>
     // this cannot happen until the event that indicates components are loaded
     $(document).on("runestone:login-complete", function () {
         llmUserMessageCount = 0;
+        if (hasVote1 && !hasReflection) {
+            setReflectionPanelEnabled(true);
+        }
         logPeerEvent({
             sid: eBookConfig.username,
             div_id: `${assignId}`,
             event: "peer",
             act: "start_async",
             course_name: eBookConfig.course,
         })
-        setTimeout(function () {
+        let bindAttempts = 0;
+        const bindVoteHandler = function () {
           const btn = window.componentMap[currentQuestion]?.submitButton;
-          if (!btn) return;
+          if (!btn) {
+            bindAttempts += 1;
+            if (bindAttempts < 40) {
+              setTimeout(bindVoteHandler, 100);
+            }
+            return;
+          }
 
           $(btn).off("click.pi_async").on("click.pi_async", function () {
+            if (window._vote1Locked && !window._vote2Enabled) {
+              return;
+            }
             const currAnswer = window.componentMap[currentQuestion].answer;
             const sAnswer = answerToString(currAnswer);
             $("#current_answer").html(sAnswer);
@@ -519,15 +566,7 @@ <h3>Congratulations, you have completed this assignment!</h3>
                 vote2Btn.title = "Send at least one LLM message to unlock";
               }
               window._hasVote1 = true;
-
-              const panel = document.getElementById("reflectionPanel");
-              if (panel) {
-                panel.style.opacity = "1";
-                panel.style.pointerEvents = "auto";
-              }
-
-              const notice = document.getElementById("vote1Notice");
-              if (notice) notice.remove();
+              setReflectionPanelEnabled(true);
 
               return;
             }
@@ -549,7 +588,8 @@ <h3>Congratulations, you have completed this assignment!</h3>
               }
             }
           });
-        }, 2000);
+        };
+        bindVoteHandler();
     });
 </script>
 <script>