Handle case where no available question

Author: bnmnetp

runestone/selectquestion/js/selectone.js

@@ -89,7 +89,7 @@ export default class SelectOne extends RunestoneBase {
             alert(
                 `Error: Not able to find a question for ${selectorId} based on the criteria`
             );
-            return response;
+            throw new Error(`Unable to find a question for ${selectorId}`);
         }
         let res;
         if (opts.timed) {

runestone/timed/css/timed.css

@@ -5,17 +5,15 @@ ul#pageNums li {
     padding: 10px 0;
 }
 
-
-.pagination>li>a:hover {
+.pagination > li > a:hover {
     background-color: #eee !important;
     color: #000 !important;
 }
 
-
 /* The following override styles in Bootstrap distribution file (bootstrap.min.css) */
 
-.pagination>.active>a,
-.pagination>.active>span {
+.pagination > .active > a,
+.pagination > .active > span {
     background-color: #428bca !important;
     color: #ffffff !important;
 }
@@ -27,37 +25,40 @@ ul#pageNums li {
 
 /* end */
 
-
-
-.pagination>.answered>a,
-.pagination>.answered>span {
+.pagination > .answered > a,
+.pagination > .answered > span {
     background-color: #eee;
     color: #000;
 }
 
-.pagination>.correctCount>a,
-.pagination>.correctCount>span {
+.pagination > .broken > a,
+.pagination > .broken > span {
+    background-color: #f99;
+    color: #000;
+}
+
+.pagination > .correctCount > a,
+.pagination > .correctCount > span {
     background-color: #dff0d8;
     color: #000000;
     border-color: #000000;
 }
 
-.pagination>.skippedCount>a,
-.pagination>.skippedCount>span {
+.pagination > .skippedCount > a,
+.pagination > .skippedCount > span {
     background-color: #fcf8e3;
     color: #000000;
     border-color: #000000;
 }
 
-.pagination>.incorrectCount>a,
-.pagination>.incorrectCount>span {
+.pagination > .incorrectCount > a,
+.pagination > .incorrectCount > span {
     background-color: #f2dede;
     color: #000000;
     border-color: #000000;
 }
 
-
 .switchcontainer {
     height: 600px;
     overflow: auto;
-}
+}

runestone/timed/js/timed.js

@@ -302,6 +302,16 @@ export default class Timed extends RunestoneBase {
         this.pagNavList.addEventListener(
             "click",
             function (event) {
+                if (
+                    this.renderedQuestionArray[this.currentQuestionIndex]
+                        .state == "broken_exam"
+                ) {
+                    $(
+                        "ul#pageNums > ul > li:eq(" +
+                            this.currentQuestionIndex +
+                            ")"
+                    ).addClass("broken");
+                }
                 if (
                     this.renderedQuestionArray[this.currentQuestionIndex]
                         .question.isAnswered
@@ -358,6 +368,16 @@ export default class Timed extends RunestoneBase {
         this.qNumList.addEventListener(
             "click",
             function (event) {
+                if (
+                    this.renderedQuestionArray[this.currentQuestionIndex]
+                        .state == "broken_exam"
+                ) {
+                    $(
+                        "ul#pageNums > ul > li:eq(" +
+                            this.currentQuestionIndex +
+                            ")"
+                    ).addClass("broken");
+                }
                 if (
                     this.renderedQuestionArray[this.currentQuestionIndex]
                         .question.isAnswered
@@ -538,13 +558,21 @@ export default class Timed extends RunestoneBase {
                 this.renderedQuestionArray[this.currentQuestionIndex] = {
                     question: newq,
                 };
-                await newq.initialize();
+                try {
+                    await newq.initialize();
+                } catch (e) {
+                    this.renderedQuestionArray[
+                        this.currentQuestionIndex
+                    ].state = "broken_exam";
+                }
             } else if ($(tmpChild).is("[data-component]")) {
                 let componentKind = $(tmpChild).data("component");
                 this.renderedQuestionArray[this.currentQuestionIndex] = {
                     question: window.component_factory[componentKind](opts),
                 };
             }
+        } else if (opts.state === "broken_exam") {
+            return;
         }
 
         currentQuestion = this.renderedQuestionArray[this.currentQuestionIndex]
@@ -562,8 +590,10 @@ export default class Timed extends RunestoneBase {
             }
         }
 
-        $(this.switchDiv).replaceWith(currentQuestion.containerDiv);
-        this.switchDiv = currentQuestion.containerDiv;
+        if (currentQuestion.containerDiv) {
+            $(this.switchDiv).replaceWith(currentQuestion.containerDiv);
+            this.switchDiv = currentQuestion.containerDiv;
+        }
 
         // If the timed component has listeners, those might need to be reinitialized
         // This flag will only be set in the elements that need it--it will be undefined in the others and thus evaluate to false