Standardize load handlers.

In js files use $(function) instead of deprecated $(document).ready(function). It gracefully handles situations in which the scripts are loaded after window.load has already fired.
In code in html or injected into html, use window.load to guarantee script availability

Author: ascholerChemeketa

runestone/activecode/js/activecode.js

@@ -132,7 +132,7 @@ export class ActiveCode extends RunestoneBase {
         );
         if (this.autorun) {
             // Simulate pressing the run button, since this will also prevent the user from clicking it until the initial run is complete, and also help the user understand why they're waiting.
-            $(document).ready(this.runButtonHandler.bind(this));
+            $(this.runButtonHandler.bind(this));
         }
         this.indicate_component_ready();
     }

runestone/animation/chart.html

@@ -18,7 +18,7 @@
 //	$("#visualization").gchart({type: 'graphviz', series: [$.gchart.series([20, 50, 30])]});
 // label: '<f0> left | <f1> middle | <f2> right'
 
-document.addEventListener('load', (event) => {
+window.addEventListener('load', (event) => {
 $('#visualization').gchart($.gchart.graphviz(true,
  {
  struct1: {label: '<f0> left |<f1> middle |<f2> right'},

runestone/animation/jqchart/gChartBasic.html

@@ -9,7 +9,7 @@
 <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.6.1/jquery.min.js"></script>
 <script src="jquery.gchart.js"></script>
 <script>
-document.addEventListener('load', (event) => {
+window.addEventListener('load', (event) => {
 $(function () {
 	$('#basicGChart').gchart({type: 'line', maxValue: 40,
 		title: 'Weather for|Brisbane, Australia', titleColor: 'green',

runestone/codelens/js/codelens.js

@@ -49,7 +49,7 @@ if (typeof allVsualizers === "undefined") {
     window.allVisualizers = [];
 }
 
-$(document).ready(function () {
+$(function () {
     if (typeof allTraceData !== "undefined") {
         for (let divid in allTraceData) {
             let cl = document.getElementById(divid);
@@ -69,7 +69,7 @@ $(document).ready(function () {
                 console.log(err);
             }
         }
-        document.addEventListener("codelens:answer", function (evt) {
+        window.addEventListener("codelens:answer", function (evt) {
             let rb = new RunestoneBase();
             rb.logBookEvent({
                 event: "codelens",

runestone/common/js/bookfuncs.js

@@ -222,7 +222,7 @@ function notifyRunestoneComponents() {
 }
 
 // initialize stuff
-$(document).ready(function () {
+$(function () {
     if (eBookConfig) {
         handlePageSetup();
     } else {
@@ -236,7 +236,7 @@ $(document).ready(function () {
 
 // misc stuff
 // todo:  This could be further distributed but making a video.js file just for one function seems dumb.
-$(document).ready(function () {
+window.addEventListener("load", function () {
     // add the video play button overlay image
     $(".video-play-overlay").each(function () {
         $(this).css(

runestone/common/js/presenter_mode.js

@@ -211,7 +211,6 @@ function configureCodelens() {
     }
 }
 
-//$(document).ready(configure);
 $(document).bind("runestone:login-complete", function () {
     // if user is instructor, enable presenter mode
     if (eBookConfig.isInstructor) {

runestone/common/project_template/_templates/plugin_layouts/sphinx_bootstrap/layout.html

@@ -391,7 +391,7 @@
 {% endif %}
 
 <script> 
-  document.addEventListener('load', (event) => {
+  window.addEventListener('load', (event) => {
     runestoneComponents.getSwitch(); 
   });
 </script>

runestone/common/project_template/_templates/plugin_layouts/sphinx_bootstrap/progress.html

@@ -65,7 +65,7 @@
             document.getElementById("progressBar").style.width = book.curChapterPercent-1 + "%";
         }
     }
-    document.addEventListener('DOMContentLoaded', function() {
+    window.addEventListener('load', function() {
         loadProgressBar();
     }, false);
 </script>

runestone/common/project_template/_templates/plugin_layouts/sphinx_bootstrap/relations.html

@@ -25,7 +25,7 @@
           'delay': { show: 100, hide: 50}
          };
 
-  document.addEventListener('load', (event) => {
+  window.addEventListener('load', (event) => {
     $('#relations-prev').tooltip(opts);
     $('#relations-next').tooltip(opts);
   });

runestone/common/project_template/_templates/plugin_layouts/sphinx_bootstrap/static/bootstrap-sphinx.js

@@ -51,7 +51,7 @@
       .attr("border", 0);
   };
 
-  $(document).ready(function () {
+$(function () {
 
     /*
      * Scroll the window to avoid the topnav bar