Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Commit 9babff2

Browse files
committed
Fix: Return data from the server, instead of the HTTP resposne, from logBookEvent.
1 parent fb0fb82 commit 9babff2

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

runestone/common/js/runestonebase.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,12 @@ export default class RunestoneBase {
5757
}
5858
}
5959

60+
// This function sends the provided ``eventInfo`` to the ``hsblog`` endpoint of the server. Awaiting this function returns either ``undefined`` (if Runestone services are not available) or the data returned by the server as a JavaScript object (already JSON-decoded).
6061
async logBookEvent(eventInfo) {
6162
if (this.graderactive) {
6263
return;
6364
}
64-
let post_return = Promise.resolve();
65+
let post_return;
6566
eventInfo.course = eBookConfig.course;
6667
eventInfo.clientLoginStatus = eBookConfig.isLoggedIn;
6768
eventInfo.timezoneoffset = new Date().getTimezoneOffset() / 60;
@@ -78,10 +79,11 @@ export default class RunestoneBase {
7879
headers: headers,
7980
body: JSON.stringify(eventInfo),
8081
});
81-
post_return = await fetch(request);
82-
if (!post_return.ok) {
82+
let response = await fetch(request);
83+
if (!response.ok) {
8384
throw new Error("Failed to save the log entry");
8485
}
86+
post_return = response.json();
8587
}
8688
console.log("logging event " + JSON.stringify(eventInfo));
8789
if (

runestone/fitb/js/fitb.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,10 +241,9 @@ export default class FITB extends RunestoneBase {
241241
}
242242
if (logFlag) {
243243
// Sometimes we don't want to log the answer--for example, when timed exam questions are re-loaded
244-
let ret = await this.logCurrentAnswer();
244+
let data = await this.logCurrentAnswer();
245245
if (!this.feedbackArray) {
246246
// On success, update the feedback from the server's grade.
247-
let data = await ret.json();
248247
this.setLocalStorage({
249248
answer: JSON.stringify(this.given_arr),
250249
timestamp: data.timestamp,

0 commit comments

Comments
 (0)