Some more cleanup

Author: SethPoulsen

runestone/parsons/js/dagHelpers.js

@@ -1,36 +1,24 @@
+"use strict";
 /**
  * This file adapted from JSNetworkX: https://github.com/fkling/JSNetworkX
  * Copyright (C) 2012 Felix Kling <felix.kling@gmx.net>
  * JSNetworkX is distributed with the BSD license
  */
 
-function isObjectLike(value) {
-  return !!value && typeof value == 'object';
-}
-
-function isBoolean(value) {
-  var boolTag = '[object Boolean]';
-  return value === true || value === false || (isObjectLike(value) && Object.prototype.toString.call(value) == boolTag);
-}
-
-function nodesAreEqual(a, b) {
-  return a === b || typeof a === 'object' && a.toString() === b.toString();
-}
-
 export function hasPath(G, {source, target}) {
-    try {
-      shortestPath(G, {source, target});
-    } catch(error) {
-      if (error instanceof JSNetworkXNoPath) {
-        return false;
-      }
-      throw error;
+  try {
+    bidirectionalShortestPath(G, source, target)
+  } catch(error) {
+    if (error instanceof JSNetworkXNoPath) {
+      return false;
     }
-    return true;
+    throw error;
   }
+  return true;
+}
 
-function shortestPath(G, {source, target, weight}={}) {
-  return bidirectionalShortestPath(G, source, target);
+function nodesAreEqual(a, b) {
+  return a === b || typeof a === 'object' && a.toString() === b.toString();
 }
 
 function bidirectionalShortestPath(G, source, target) {
@@ -107,7 +95,7 @@ function bidirectionalPredSucc(G, source, target) {
       }
     }
   }
-  throw new JSNetworkXNoPath('No path between ' + source + ' and ' + target + ".");
+  throw new JSNetworkXNoPath('No path between ' + source + ' and ' + target + '.');
 }
 
 function topologicalSort(G, optNbunch) {
@@ -389,3 +377,13 @@ class JSNetworkXNoPath extends JSNetworkXUnfeasible {
     this.name = 'JSNetworkXNoPath';
   }
 }
+
+// functions from LoDash, needed by functions from JSNetworkX
+function isObjectLike(value) {
+  return !!value && typeof value == 'object';
+}
+
+function isBoolean(value) {
+  var boolTag = '[object Boolean]';
+  return value === true || value === false || (isObjectLike(value) && Object.prototype.toString.call(value) == boolTag);
+}