Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Commit 8bfdcd2

Browse files
committed
Use subprocess.call to ensure build completes
1 parent 803ed94 commit 8bfdcd2

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

runestone/unittest_base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ def setUpModule(self):
7070
# Change to this directory for running Runestone.
7171
self.old_cwd = os.getcwd()
7272
os.chdir(self.base_path)
73-
p = subprocess.Popen(
73+
# use call so that npm run build completes before we move on to runestone build
74+
# otherwise the runestone build may fail due to lack of a runestone.js file!
75+
p = subprocess.call(
7476
["npm.cmd" if IS_WINDOWS else "npm", "run", "build"],
7577
stdout=subprocess.PIPE,
7678
stderr=subprocess.PIPE,

0 commit comments

Comments
 (0)