Wait for text to be ready the proper way

Author: bnmnetp

runestone/activecode/test/test_activecode.py

@@ -31,6 +31,10 @@ def test_hello(self):
         self.assertIsNotNone(rb)
         rb.click()
         time.sleep(0.5)
+        wait = WebDriverWait(self.driver, 10)
+        wait.until(
+            EC.text_to_be_present_in_element((By.ID, "test1_stdout"), "Hello")
+        )
         output = t1.find_element_by_class_name("ac_output")
         self.assertEqual(output.text.strip(), "Hello World")
 
@@ -54,7 +58,9 @@ def test_hidden(self):
         rb = t1.find_element_by_class_name("run-button")
         self.assertIsNotNone(rb)
         rb.click()
-        time.sleep(0.5)
+        wait.until(
+            EC.text_to_be_present_in_element((By.ID, "testprefixcode_stdout"), "My")
+        )
         output = t1.find_element_by_class_name("ac_output")
         self.assertIn("My Code", output.text.strip())
         self.assertIn("hidden code", output.text.strip())
@@ -173,7 +179,10 @@ def test_sql_activecode(self):
         rb = t2.find_element_by_class_name("run-button")
         self.assertIsNotNone(rb)
         rb.click()
-        time.sleep(0.5)
+        wait = WebDriverWait(self.driver, 10)
+        wait.until(
+            EC.text_to_be_present_in_element((By.ID, "sql1_stdout"), "You")
+        )
         res = self.driver.find_element_by_id("sql1_sql_out")
         self.assertIsNotNone(res)
         out = self.driver.find_element_by_id("sql1_stdout")
@@ -195,6 +204,10 @@ def test_readfiles(self):
         rb = t2.find_element_by_class_name("run-button")
         self.assertIsNotNone(rb)
         rb.click()
+        wait = WebDriverWait(self.driver, 10)
+        wait.until(
+            EC.text_to_be_present_in_element((By.ID, "ac9_13_1_stdout"), "Lind")
+        )
         out = t2.find_element_by_id("ac9_13_1_stdout")
         self.assertIsNotNone(out)
         self.assertTrue("Lindenau" in out.text)
@@ -208,7 +221,10 @@ def test_altair(self):
         rb.click()
         out = t2.find_element_by_id("alt_kiva_bar1_stdout")
         self.assertIsNotNone(out)
-        time.sleep(.5)
+        wait = WebDriverWait(self.driver, 10)
+        wait.until(
+            EC.text_to_be_present_in_element((By.ID, "alt_kiva_bar1_stdout"), "mark")
+        )
         self.assertIn("mark = bar", out.text)
         self.assertIn("{'field': 'customer', 'type': 'nominal'}", out.text)
         can = t2.find_element_by_tag_name("canvas")
@@ -221,9 +237,12 @@ def test_image(self):
         rb = t2.find_element_by_class_name("run-button")
         self.assertIsNotNone(rb)
         rb.click()
+        wait = WebDriverWait(self.driver, 10)
+        wait.until(
+            EC.text_to_be_present_in_element((By.ID, "ac14_7_2_stdout"), "400")
+        )
         out = t2.find_element_by_id("ac14_7_2_stdout")
         self.assertIsNotNone(out)
-        time.sleep(1)
         self.assertTrue("400" in out.text)
         self.assertTrue("244" in out.text)
         self.assertTrue(("165 161 158" in out.text) or ("165 162 157" in out.text))