chore(voip): dead-code and hygiene sweep (#7174)

Author: diegolmello

MERGE_NOTES.md

@@ -4,6 +4,7 @@ export default {
 	displayIncomingCall: jest.fn(),
 	endCall: jest.fn(),
 	setCurrentCallActive: jest.fn(),
+	setAvailable: jest.fn(),
 	addEventListener: jest.fn((event, callback) => ({
 		remove: jest.fn()
 	}))

__mocks__/react-native-callkeep.js

@@ -0,0 +1,52 @@
+import { parseStringToIceServers } from './parseStringToIceServers';
+
+describe('parseStringToIceServers', () => {
+	it('returns empty array for empty input', () => {
+		expect(parseStringToIceServers('')).toEqual([]);
+	});
+
+	it('returns empty array for whitespace-only input', () => {
+		expect(parseStringToIceServers('   ')).toEqual([]);
+	});
+
+	it('parses STUN-only server', () => {
+		expect(parseStringToIceServers('stun:stun.example.com:3478')).toEqual([{ urls: 'stun:stun.example.com:3478' }]);
+	});
+
+	it('parses TURN server with username and credential', () => {
+		const input = 'user:secret@turn:turn.example.com:3478?transport=udp';
+		expect(parseStringToIceServers(input)).toEqual([
+			{
+				urls: 'turn:turn.example.com:3478?transport=udp',
+				username: 'user',
+				credential: 'secret'
+			}
+		]);
+	});
+
+	it('decodes URI-encoded username and credential', () => {
+		const user = encodeURIComponent('user:with:colons');
+		const cred = encodeURIComponent('p@ss/word');
+		const input = `${user}:${cred}@turns:turn.example.com:5349`;
+		expect(parseStringToIceServers(input)).toEqual([
+			{
+				urls: 'turns:turn.example.com:5349',
+				username: 'user:with:colons',
+				credential: 'p@ss/word'
+			}
+		]);
+	});
+
+	it('parses comma-separated list', () => {
+		const a = 'stun:stun1.example.com';
+		const b = 'u:p@turn:turn.example.com';
+		expect(parseStringToIceServers(`${a},${b}`)).toEqual([
+			{ urls: a },
+			{ urls: 'turn:turn.example.com', username: 'u', credential: 'p' }
+		]);
+	});
+
+	it('tolerates malformed tokens without throwing', () => {
+		expect(parseStringToIceServers('@@@')).toEqual([{ urls: '' }]);
+	});
+});

app/lib/services/voip/mockCall.ts

@@ -1,6 +1,6 @@
 import type { IceServer } from '../../../definitions/Voip';
 
-export const parseStringToIceServer = (server: string): IceServer => {
+function parseStringToIceServer(server: string): IceServer {
 	const credentials = server.trim().split('@');
 	const urls = credentials.pop() as string;
 	const [username, credential] = credentials.length === 1 ? credentials[0].split(':') : [];
@@ -13,7 +13,7 @@ export const parseStringToIceServer = (server: string): IceServer => {
 				credential: decodeURIComponent(credential)
 			})
 	};
-};
+}
 
 export const parseStringToIceServers = (string: string): IceServer[] => {
 	if (!string) {

app/lib/services/voip/parseStringToIceServers.test.ts

@@ -21,7 +21,8 @@ jest.mock('react-native-callkeep', () => ({
 	setAvailable: jest.fn()
 }));
 
-function createMockCall(callId: string) {
+function createMockCall(callId: string, options?: { initialState?: string }) {
+	const initialState = options?.initialState ?? 'active';
 	const listeners: Record<string, Set<(...args: unknown[]) => void>> = {};
 	const emitter = {
 		on: (ev: string, fn: (...args: unknown[]) => void) => {
@@ -55,7 +56,7 @@ function createMockCall(callId: string) {
 	];
 	const call = {
 		callId,
-		state: 'active',
+		state: initialState,
 		hidden: false,
 		localParticipant,
 		remoteParticipants,
@@ -98,13 +99,6 @@ describe('useCallStore controlsVisible', () => {
 		expect(useCallStore.getState().controlsVisible).toBe(true);
 	});
 
-	it('showControls sets true when hidden', () => {
-		useCallStore.getState().toggleControlsVisible();
-		expect(useCallStore.getState().controlsVisible).toBe(false);
-		useCallStore.getState().showControls();
-		expect(useCallStore.getState().controlsVisible).toBe(true);
-	});
-
 	it('auto-shows controls on stateChange event', () => {
 		const { call, emit } = createMockCall('c1');
 		useCallStore.getState().setCall(call);
@@ -160,6 +154,39 @@ describe('useCallStore roomId', () => {
 		useCallStore.getState().reset();
 		expect(useCallStore.getState().roomId).toBeNull();
 	});
+
+	it('setRoomId persists across setCall until reset', () => {
+		useCallStore.getState().setRoomId('room-persist-1');
+		const { call } = createMockCall('persist-call');
+		useCallStore.getState().setCall(call);
+		expect(useCallStore.getState().roomId).toBe('room-persist-1');
+	});
+});
+
+describe('useCallStore callStartTime', () => {
+	beforeEach(() => {
+		useCallStore.getState().resetNativeCallId();
+		useCallStore.getState().reset();
+	});
+
+	afterEach(() => {
+		jest.useRealTimers();
+	});
+
+	it('sets callStartTime when transitioning ringing to active', () => {
+		jest.useFakeTimers();
+		const fixed = new Date('2020-01-01T00:00:00.000Z');
+		jest.setSystemTime(fixed);
+		const { call, emit } = createMockCall('ring-to-active', { initialState: 'ringing' });
+		useCallStore.getState().setCall(call);
+		expect(useCallStore.getState().callStartTime).toBeNull();
+
+		(call as { state: string }).state = 'active';
+		emit('stateChange');
+
+		expect(useCallStore.getState().callStartTime).toBe(fixed.getTime());
+		expect(useCallStore.getState().callState).toBe('active');
+	});
 });
 
 describe('useCallStore native accepted + stale timer', () => {

app/lib/services/voip/parseStringToIceServers.ts

@@ -14,7 +14,7 @@ let staleNativeTimer: ReturnType<typeof setTimeout> | null = null;
 /** Call id this timer is for; only `nativeAcceptedCallId` is cleared when it fires, not `callId`. */
 let staleNativeScheduledId: string | null = null;
 
-export function cleanupCallListeners(): void {
+function cleanupCallListeners(): void {
 	callListenersCleanup?.();
 	callListenersCleanup = null;
 }
@@ -89,7 +89,6 @@ interface CallStoreActions {
 	toggleHold: () => void;
 	toggleSpeaker: () => void;
 	toggleControlsVisible: () => void;
-	showControls: () => void;
 	toggleFocus: () => void;
 	endCall: () => void;
 	/** Clears UI/call fields but keeps nativeAcceptedCallId. Restarts the 15s timer (media init calls reset and clears the old timer first). */
@@ -220,10 +219,6 @@ export const useCallStore = create<CallStore>((set, get) => ({
 		set({ controlsVisible: !get().controlsVisible });
 	},
 
-	showControls: () => {
-		set({ controlsVisible: true });
-	},
-
 	toggleMute: () => {
 		const { call, isMuted } = get();
 		if (!call) return;
@@ -310,11 +305,6 @@ export const useCallStore = create<CallStore>((set, get) => ({
 	}
 }));
 
-export const useCallState = () => {
-	const callState = useCallStore(state => state.callState);
-	return callState === 'none' || callState === 'ringing' || callState === 'accepted';
-};
-
 export const useCallContact = () => useCallStore(state => state.contact);
 export const useDialpadValue = () => useCallStore(state => state.dialpadValue);
 export const useControlsVisible = () => {

app/lib/services/voip/useCallStore.test.ts

@@ -7,7 +7,6 @@ import { E2E_BANNER_TYPE } from '../../../lib/constants/keys';
 import { themes } from '../../../lib/constants/colors';
 import { useAppSelector } from '../../../lib/hooks/useAppSelector';
 import { events, logEvent } from '../../../lib/methods/helpers/log';
-import { launchMockCallView } from '../../../lib/services/voip/mockCall';
 import { useTheme } from '../../../theme';
 import { RoomsSearchContext } from '../contexts/RoomsSearchProvider';
 
@@ -40,18 +39,6 @@ const ListHeader = () => {
 
 	return (
 		<>
-			{__DEV__ ? (
-				<>
-					<List.Item
-						title={'Mock Call (dev)'}
-						left={() => <List.Icon name='phone' />}
-						onPress={() => launchMockCallView()}
-						testID='listheader-mock-call'
-						translateTitle={false}
-					/>
-					<List.Separator />
-				</>
-			) : null}
 			{encryptionBanner ? (
 				<>
 					<List.Item