Check if Memcached key exists

Author: RobiNN1

src/Dashboards/Memcached/MemcacheCompatibility/RunCommandTrait.php

@@ -107,11 +107,26 @@ public function getKeys(): array {
      *
      * @param string $key
      *
-     * @return string
+     * @return string|false
      */
-    public function getKey(string $key): string {
+    public function getKey(string $key) {
         $data = $this->runCommand('get '.$key);
 
-        return $data[1];
+        if (!isset($data[0])) {
+            return false;
+        }
+
+        return !isset($data[1]) || $data[1] === 'N;' ? '' : $data[1];
+    }
+
+    /**
+     * Check if key exists.
+     *
+     * @param string $key
+     *
+     * @return bool
+     */
+    public function exists(string $key): bool {
+        return $this->getKey($key) !== false;
     }
 }

src/Dashboards/Memcached/MemcachedTrait.php

@@ -78,7 +78,7 @@ private function deleteAllKeys($memcached): string {
     private function deleteKey($memcached): string {
         $keys = explode(',', Http::get('delete'));
 
-        if (count($keys) === 1 && @$memcached->get($keys[0]) !== false) {
+        if (count($keys) === 1 && $memcached->exists($keys[0])) {
             $memcached->delete($keys[0]);
             $message = sprintf('Key "%s" has been deleted.', $keys[0]);
         } elseif (count($keys) > 1) {
@@ -175,7 +175,7 @@ private function mainDashboard($memcached): string {
     private function viewKey($memcached): string {
         $key = Http::get('key');
 
-        if ($memcached->get($key) === false) {
+        if (!$memcached->exists($key)) {
             Http::redirect();
         }
 
@@ -223,7 +223,7 @@ private function import($memcached): void {
         if ($_FILES['import']['type'] === 'text/plain') {
             $key_name = Http::post('key_name');
 
-            if ($memcached->get($key_name) === false) {
+            if (!$memcached->exists($key_name)) {
                 $value = file_get_contents($_FILES['import']['tmp_name']);
 
                 $memcached->store($key_name, $value, Http::post('expire', 'int'));
@@ -248,7 +248,7 @@ private function form($memcached): string {
         $encoder = Http::get('encoder', 'string', 'none');
         $value = Http::post('value');
 
-        if (isset($_GET['key']) && $memcached->get($key)) {
+        if (isset($_GET['key']) && $memcached->exists($key)) {
             $value = $memcached->getKey($key);
         }