Apply suggestions from code review

Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>

Author: Noseey

libs/s25main/GamePlayer.cpp

@@ -807,8 +807,7 @@ bool GamePlayer::FindWarehouseForJob(const Job job, noRoadNode& goal) const
     // Optimization: return early if building is isolated
     if(goal.GetType() == NodalObjectType::Building || goal.GetType() == NodalObjectType::Buildingsite)
     {
-        auto* bld = static_cast<noBaseBuilding*>(&goal);
-        if(!bld->IsConnected())
+        if(!static_cast<noBaseBuilding&>(goal).IsConnected())
             return false;
     }
 
@@ -1034,7 +1033,7 @@ noBaseBuilding* GamePlayer::FindClientForWare(const Ware& ware)
             // Bei Baustellen die Extraliste abfragen
             for(noBuildingSite* bldSite : buildings.GetBuildingSites())
             {
-                // Optimization: return early if building is isolated
+                // Optimization: Ignore if unconnected
                 if(!bldSite->IsConnected())
                     continue;
 
@@ -1051,7 +1050,7 @@ noBaseBuilding* GamePlayer::FindClientForWare(const Ware& ware)
             // Für übrige Gebäude
             for(nobUsual* bld : buildings.GetBuildings(bldType))
             {
-                // Optimization: return early if building is isolated
+                // Optimization: Ignore if unconnected
                 if(!bld->IsConnected())
                     continue;
 
@@ -1156,7 +1155,7 @@ nobBaseMilitary* GamePlayer::FindClientForCoin(const Ware& ware) const
     // Militärgebäude durchgehen
     for(nobMilitary* milBld : buildings.GetMilitaryBuildings())
     {
-        // Optimization: return early if building is isolated
+        // Optimization: Ignore if unconnected
         if(!milBld->IsConnected())
             continue;
 

libs/s25main/buildings/noBaseBuilding.cpp

@@ -209,12 +209,11 @@ MapPoint noBaseBuilding::GetFlagPos() const
 
 bool noBaseBuilding::IsConnected() const
 {
-    const helpers::EnumArray<RoadSegment*, Direction> routes = this->GetFlag()->getRoutes();
-
     // Harbors are always considered connected via sea
-    if(this->GetBuildingType() == BuildingType::HarborBuilding)
+    if(GetBuildingType() == BuildingType::HarborBuilding)
         return true;
 
+    const helpers::EnumArray<RoadSegment*, Direction>& routes = GetFlag()->getRoutes();
     // Check paths in all directions except back to building
     for(const auto dir : helpers::EnumRange<Direction>{})
     {