Optimize for RVO

Author: Flamefire

libs/common/src/System_Other.cpp

@@ -32,7 +32,7 @@ boost::filesystem::path System::getHomePath()
 
 std::string System::getUserName()
 {
-    const std::string name = getEnvVar("USER");
+    std::string name = getEnvVar("USER");
     if(name.empty())
         throw std::runtime_error("Could not get username");
     return name;

libs/common/src/Tokenizer.cpp

@@ -33,7 +33,7 @@ std::string Tokenizer::next()
         return "";
 
     const auto newPos = data.find_first_of(delimiter, curPos);
-    const auto result = data.substr(curPos, newPos - curPos);
+    auto result = data.substr(curPos, newPos - curPos);
 
     curPos = (newPos == std::string::npos) ? newPos : newPos + 1;
     return result;