Merge pull request #83 from ReSwift/mokagio/fix-fatal-error-messages

mokagio · web-flow · commit ba52e46d8721 · 2017-10-18T08:51:56.000+11:00
Provide more information on Routable fatalErrors
diff --git a/ReSwiftRouter/Routable.swift b/ReSwiftRouter/Routable.swift
@@ -34,22 +34,22 @@ extension Routable {
         _ routeElementIdentifier: RouteElementIdentifier,
         animated: Bool,
         completionHandler: @escaping RoutingCompletionHandler) -> Routable {
-            fatalError("This routable cannot change segments. You have not implemented it.")
+            fatalError("This routable cannot push segments. You have not implemented it. (Asked \(type(of: self)) to push \(routeElementIdentifier))")
     }
 
     public func popRouteSegment(
         _ routeElementIdentifier: RouteElementIdentifier,
         animated: Bool,
         completionHandler: @escaping RoutingCompletionHandler) {
-            fatalError("This routable cannot change segments. You have not implemented it.")
+            fatalError("This routable cannot pop segments. You have not implemented it. (Asked \(type(of: self)) to pop \(routeElementIdentifier))")
     }
 
     public func changeRouteSegment(
         _ from: RouteElementIdentifier,
         to: RouteElementIdentifier,
         animated: Bool,
         completionHandler: @escaping RoutingCompletionHandler) -> Routable {
-            fatalError("This routable cannot change segments. You have not implemented it.")
+            fatalError("This routable cannot change segments. You have not implemented it. (Asked \(type(of: self)) to change from \(from) to \(to))")
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -34,22 +34,22 @@ extension Routable {`
`34`	`34`	`_ routeElementIdentifier: RouteElementIdentifier,`
`35`	`35`	`animated: Bool,`
`36`	`36`	`completionHandler: @escaping RoutingCompletionHandler) -> Routable {`
`37`		`- fatalError("This routable cannot change segments. You have not implemented it.")`
	`37`	`+ fatalError("This routable cannot push segments. You have not implemented it. (Asked \(type(of: self)) to push \(routeElementIdentifier))")`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`public func popRouteSegment(`
`41`	`41`	`_ routeElementIdentifier: RouteElementIdentifier,`
`42`	`42`	`animated: Bool,`
`43`	`43`	`completionHandler: @escaping RoutingCompletionHandler) {`
`44`		`- fatalError("This routable cannot change segments. You have not implemented it.")`
	`44`	`+ fatalError("This routable cannot pop segments. You have not implemented it. (Asked \(type(of: self)) to pop \(routeElementIdentifier))")`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`public func changeRouteSegment(`
`48`	`48`	`_ from: RouteElementIdentifier,`
`49`	`49`	`to: RouteElementIdentifier,`
`50`	`50`	`animated: Bool,`
`51`	`51`	`completionHandler: @escaping RoutingCompletionHandler) -> Routable {`
`52`		`- fatalError("This routable cannot change segments. You have not implemented it.")`
	`52`	`+ fatalError("This routable cannot change segments. You have not implemented it. (Asked \(type(of: self)) to change from \(from) to \(to))")`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`}`