We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent ead46e7 commit f2fc71aCopy full SHA for f2fc71a
1 file changed
core/field_colour.ts
@@ -246,12 +246,9 @@ export class FieldColour extends Field<string> {
246
247
const block = this.getSourceBlock() as BlockSvg | null;
248
if (!block) throw new UnattachedFieldError();
249
- // In general, do *not* let fields control the color of blocks. Having the
250
- // field control the color is unexpected, and could have performance
251
- // impacts.
252
- // Whenever we render, the field may no longer be a full-block-field so
253
- // we need to update the colour.
254
- if (this.getConstants()!.FIELD_COLOUR_FULL_BLOCK) block.applyColour();
+ // Calling applyColour updates the UI (full-block vs non-full-block) for the
+ // colour field, and the colour of the field/block.
+ block.applyColour();
255
}
256
257
/**
0 commit comments