Skip to content

Commit dbe926d

Browse files
fix: removed X & Y from toolbox.ts and replaced movBy to moveTo (#7333)
* fix: removed X & Y from toolbox.ts and replaced movBy to moveTo in Horizontal/ Vertical flyout * forget to run npm lint and format * removed the mistakenly added comment
1 parent 8241fca commit dbe926d

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

core/flyout_horizontal.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import type {FlyoutButton} from './flyout_button.js';
1919
import type {Options} from './options.js';
2020
import * as registry from './registry.js';
2121
import {Scrollbar} from './scrollbar.js';
22-
import type {Coordinate} from './utils/coordinate.js';
22+
import {Coordinate} from './utils/coordinate.js';
2323
import {Rect} from './utils/rect.js';
2424
import * as toolbox from './utils/toolbox.js';
2525
import * as WidgetDiv from './widgetdiv.js';
@@ -285,7 +285,8 @@ export class HorizontalFlyout extends Flyout {
285285
} else {
286286
moveX = cursorX - tab;
287287
}
288-
block!.moveBy(moveX, cursorY);
288+
// No 'reason' provided since events are disabled.
289+
block!.moveTo(new Coordinate(moveX, cursorY));
289290

290291
const rect = this.createRect_(block!, moveX, cursorY, blockHW, i);
291292
cursorX += blockHW.width + gaps[i];

core/flyout_vertical.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import type {FlyoutButton} from './flyout_button.js';
1919
import type {Options} from './options.js';
2020
import * as registry from './registry.js';
2121
import {Scrollbar} from './scrollbar.js';
22-
import type {Coordinate} from './utils/coordinate.js';
22+
import {Coordinate} from './utils/coordinate.js';
2323
import {Rect} from './utils/rect.js';
2424
import * as toolbox from './utils/toolbox.js';
2525
import * as WidgetDiv from './widgetdiv.js';
@@ -246,7 +246,8 @@ export class VerticalFlyout extends Flyout {
246246
const moveX = block!.outputConnection
247247
? cursorX - this.tabWidth_
248248
: cursorX;
249-
block!.moveBy(moveX, cursorY);
249+
// No 'reason' provided since events are disabled.
250+
block!.moveTo(new Coordinate(moveX, cursorY));
250251

251252
const rect = this.createRect_(
252253
block!,
@@ -357,7 +358,8 @@ export class VerticalFlyout extends Flyout {
357358
if (!block.outputConnection) {
358359
newX -= this.tabWidth_;
359360
}
360-
block.moveBy(newX - oldX, 0);
361+
// No 'reason' provided since events are disabled.
362+
block.moveTo(new Coordinate(newX - oldX, 0));
361363
}
362364
if (this.rectMap_.has(block)) {
363365
this.moveRectToBlock_(this.rectMap_.get(block)!, block);

core/utils/toolbox.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ export interface BlockInfo {
2424
disabled?: string | boolean;
2525
enabled?: boolean;
2626
id?: string;
27-
x?: number;
28-
y?: number;
2927
collapsed?: boolean;
3028
inline?: boolean;
3129
data?: string;

0 commit comments

Comments
 (0)